Update tests

Author: danieldk

kernels-data/bindings/python/tests/test_digest.py

@@ -1,4 +1,6 @@
-from kernels_data import Digest
+import pytest
+
+from kernels_data import Digest, DigestValidationError, DigestViolation
 
 
 def test_hash_variant_hashes_file_with_sha256(tmp_path):
@@ -70,10 +72,11 @@ def test_validate_returns_no_violations_for_identical_digests(tmp_path):
     expected = Digest.hash_variant("sha256", tmp_path)
     actual = Digest.hash_variant("sha256", tmp_path)
 
-    assert expected.validate(actual) == []
+    expected.validate(actual)
 
 
-def test_validate_reports_missing_unknown_and_mismatched_files(tmp_path):
+@pytest.fixture
+def mismatched_digests(tmp_path):
     expected_dir = tmp_path / "expected"
     actual_dir = tmp_path / "actual"
     expected_dir.mkdir()
@@ -91,12 +94,61 @@ def test_validate_reports_missing_unknown_and_mismatched_files(tmp_path):
 
     expected = Digest.hash_variant("sha256", expected_dir)
     actual = Digest.hash_variant("sha256", actual_dir)
+    return expected, actual
 
-    messages = expected.validate(actual)
 
-    assert "Missing file: gone.py" in messages
-    assert "Unknown file: extra.bin" in messages
-    assert any(
-        message.startswith("File hash mismatch for shared.so") for message in messages
-    )
-    assert len(messages) == 3
+def test_validate_raises_with_structured_violations(mismatched_digests):
+    expected, actual = mismatched_digests
+
+    with pytest.raises(DigestValidationError) as exc_info:
+        expected.validate(actual)
+
+    violations = exc_info.value.violations
+    assert len(violations) == 3
+
+    by_path = {v.path: v for v in violations}
+
+    assert isinstance(by_path["gone.py"], DigestViolation.MissingFile)
+    assert isinstance(by_path["extra.bin"], DigestViolation.UnknownFile)
+
+    mismatch = by_path["shared.so"]
+    assert isinstance(mismatch, DigestViolation.HashMismatch)
+    assert mismatch.expected != mismatch.got
+
+
+def test_validate_violations_support_pattern_matching(mismatched_digests):
+    expected, actual = mismatched_digests
+
+    with pytest.raises(DigestValidationError) as exc_info:
+        expected.validate(actual)
+
+    violations = exc_info.value.violations
+    assert len(violations) == 3
+
+    for violation in violations:
+        match violation:
+            case DigestViolation.MissingFile(path=path):
+                assert path == "gone.py"
+            case DigestViolation.UnknownFile(path=path):
+                assert path == "extra.bin"
+            case DigestViolation.HashMismatch(path=path):
+                assert path == "shared.so"
+            case _:
+                pytest.fail(f"unexpected violation: {violation!r}")
+
+
+def test_validate_error_str_lists_every_violation(mismatched_digests):
+    expected, actual = mismatched_digests
+
+    with pytest.raises(DigestValidationError) as exc_info:
+        expected.validate(actual)
+
+    message = str(exc_info.value)
+    assert "Missing file: gone.py" in message
+    assert "Unknown file: extra.bin" in message
+    assert "File hash mismatch for shared.so" in message
+
+    # `str(violation)` reuses the same human-readable rendering.
+    rendered = {str(v) for v in exc_info.value.violations}
+    assert "Missing file: gone.py" in rendered
+    assert "Unknown file: extra.bin" in rendered