-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Qwen2-VL generate with inputs_embeds #35466
fix: Qwen2-VL generate with inputs_embeds #35466
Conversation
Failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minostauros hey, thanks for submitting s PR!
Unfortunately, we'd like to keep the RoPE delta related code withing the forward
method as it has been causing errors in some generation techniques. The failing tests are also related to the rope deltas, some techniques call model's forward several times with the same inputs and thus position ids might not be correct in such cases. Is there any way to fix this by changing only the forward
code?
I suggest to refactor a bit the get_repo_index
and remove the dependency on input_ids
as a required argument when no video/image is passed
8a22d10
to
d1541d7
Compare
Solved failing errors.
Applied in d1541d7 |
Additionally failing tests These tests are failing in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, the failing tests you mentioned are not related to this PR and the slow tests sometimes fail unless specific hardware is used
For the new changes, we can remove the repetition in prepare_inputs
with tiny tricks. LMK if that works :)
b28244c
to
9f121fd
Compare
Thank you! Applied your suggrestions and I guess it is ready. |
9f121fd
to
b06981c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great look good to me! I guess the tests for Qwen2-VL are all passing now?
Will request a second review and we can merge then :)
Integration tests are still failing just like in test report including slow tests
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, the failing test would still need to be worked on (cuda transfer for cu seq lens and etc) but this works. THanks
I'd like to help review and contribute to this PR. Could you guide me on what improvements are needed? |
What does this PR do?
Fixes #35463
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zucchini-nlp