Skip to content

Commit e7d6e7b

Browse files
authored
Fix macos archive templates (#20)
* Update ci.yml * Update vulkan_prebuilt_helpers.sh with new macos archive format
1 parent 30ba978 commit e7d6e7b

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
versions:
1111
description: 'Vulkan SDK Versions'
1212
required: true
13-
default: '[ "1.4.309.0" ]'
13+
default: '[ "1.4.321.0" ]'
1414
oses:
1515
description: 'Matrix OSes'
1616
required: true
@@ -119,11 +119,12 @@ jobs:
119119
with:
120120
limit-access-to-actor: true
121121
- uses: ./
122+
id: composite
122123
with:
123124
version: ${{ fromJSON(github.event.inputs.versions)[0] }}
124125
cache: false
125126
- name: Setup tmate session
126-
if: ${{ contains(github.event.inputs.extra_tests, 'tmate-after') }}
127+
if: steps.composite.outcome != 'success' || ${{ contains(github.event.inputs.extra_tests, 'tmate-after') }}
127128
uses: mxschmitt/[email protected]
128129
with:
129130
limit-access-to-actor: true
@@ -147,3 +148,8 @@ jobs:
147148
cmake -B tests/build -S tests -DCMAKE_BUILD_TYPE=Release -DCMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE=.
148149
cmake --build tests/build --config release
149150
./tests/build/test_vulkan
151+
- name: Setup tmate session on failure
152+
if: failure()
153+
uses: mxschmitt/[email protected]
154+
with:
155+
limit-access-to-actor: true

vulkan_prebuilt_helpers.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,15 @@ function install_mac() {
5656
local InstallVulkan
5757
if [[ -d InstallVulkan-${VULKAN_SDK_VERSION}.app/Contents ]] ; then
5858
InstallVulkan=InstallVulkan-${VULKAN_SDK_VERSION}
59+
elif [[ -d vulkansdk-macOS-${VULKAN_SDK_VERSION}.app/Contents ]] ; then
60+
InstallVulkan=vulkansdk-macOS-${VULKAN_SDK_VERSION}
5961
elif [[ -d InstallVulkan.app/Contents ]] ; then
6062
InstallVulkan=InstallVulkan
6163
else
62-
echo "unrecognized zip/layout: vulkan_sdk.zip" >&2
64+
echo "expecting ..vulkan.app/Contents folder (perhaps lunarg changed the archive layout again?): vulkan_sdk.zip" >&2
65+
echo "file vulkan_sdk.zip" >&2
6366
file vulkan_sdk.zip
67+
echo "unzip -t vulkan_sdk.zip" >&2
6468
unzip -t vulkan_sdk.zip
6569
exit 7
6670
fi

0 commit comments

Comments
 (0)