Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we remove Sendable conformance from Response and ResponseBody? #632

Open
adam-fowler opened this issue Dec 8, 2024 · 0 comments
Open

Should we remove Sendable conformance from Response and ResponseBody? #632

adam-fowler opened this issue Dec 8, 2024 · 0 comments
Labels
breaking change Change that requires a major version

Comments

@adam-fowler
Copy link
Member

adam-fowler commented Dec 8, 2024 •
edited
Loading

They currently are Sendable but making ResponseBody Sendable means that the closure it holds needs to be Sendable as well. This complicates things when the type being written in the Response is non Sendable.
@adam-fowler adam-fowler added the breaking change Change that requires a major version label Dec 8, 2024
@adam-fowler adam-fowler changed the title Should Response and ResponseBody by Sendable? Should we remove Sendable conformance from Response and ResponseBody? Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Change that requires a major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam-fowler