Skip to content

Add HTTP/1 max header size limit #3832

Open
@myyrakle

Description

@myyrakle

Is your feature request related to a problem? Please describe.
I need "the ability to limit the size of Request Header".
Although it is possible to implement this in an application, I think it is most efficient if it can be handled at the protocol implementation level.

Describe the solution you'd like
Currently, it is supported to specify the number of headers through the "h1_max_headers" option when creating a builder. I think it would be okay to control it by adding a few properties like this.

Describe alternatives you've considered
If we implement the header max setting, there may be several ways to do this.

  1. number of header: already implemented
  2. max size of each heade name: Fixed at 64kb
  3. max size of each heade value: none (maybe)
  4. max size of total header: none

What if all of this could be set as a builder option? What do you think about this?

Question
If the problem was simple, I would implement it myself and post a PR, but a question arose while looking at the code.
Image
There is evidence of an attempt to add an option called "h1_max_header_size". What exactly is the max that this is trying to implement?

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-http1Area: HTTP/1 specific.A-serverArea: server.C-featureCategory: feature. This is adding a new feature.E-mediumEffort: medium. Some knowledge of how hyper internal works would be useful.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions