Skip to content

Commit 2d7cd58

Browse files
committed
Remove individual and draft-04 min/max handlers
1 parent b663e9d commit 2d7cd58

15 files changed

Lines changed: 13 additions & 348 deletions

File tree

src/error-handlers/draft-04/maximum.js

Lines changed: 0 additions & 64 deletions
This file was deleted.

src/error-handlers/draft-04/minimum.js

Lines changed: 0 additions & 56 deletions
This file was deleted.

src/error-handlers/exclusiveMaximum.js

Lines changed: 0 additions & 40 deletions
This file was deleted.

src/error-handlers/exclusiveMinimum.js

Lines changed: 0 additions & 41 deletions
This file was deleted.

src/hyperjump-json-schema.test.js

Lines changed: 8 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -64,19 +64,14 @@ const runTests = (dialectUri, dialect) => {
6464
unregisterSchema(schemaUri);
6565
});
6666

67-
for (const entry of await readdir(
68-
`${import.meta.dirname}/test-suite/tests`,
69-
{ withFileTypes: true }
70-
)) {
67+
for (const entry of await readdir(`${import.meta.dirname}/test-suite/tests`, { withFileTypes: true })) {
7168
if (!entry.isFile() || !entry.name.endsWith(".json")) {
7269
continue;
7370
}
7471

7572
const file = `${entry.parentPath}/${entry.name}`;
7673
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
77-
const suite = /** @type TestSuite */ (
78-
JSON.parse(await readFile(file, "utf8"))
79-
);
74+
const suite = /** @type TestSuite */ (JSON.parse(await readFile(file, "utf8")));
8075

8176
for (const testCase of suite.tests) {
8277
if (!isCompatible(testCase.compatibility, dialect)) {
@@ -104,9 +99,7 @@ const buildErrors = (errors, schemaUri) => {
10499
message: getMessage(error.messageId, error.messageParams),
105100
instanceLocation: error.instanceLocation,
106101
schemaLocations: error.schemaLocations.map((schemaLocation) => {
107-
return schemaLocation.startsWith("#")
108-
? schemaUri + schemaLocation
109-
: schemaLocation;
102+
return schemaLocation.startsWith("#") ? schemaUri + schemaLocation : schemaLocation;
110103
})
111104
};
112105

@@ -162,10 +155,7 @@ const isCompatible = (compatibility, versionUnderTest) => {
162155

163156
/** @type (messageId: string, messageParams: MessageParams) => string */
164157
const getMessage = await (async function () {
165-
const ftl = await readFile(
166-
`${import.meta.dirname}/translations/en-US.ftl`,
167-
"utf-8"
168-
);
158+
const ftl = await readFile(`${import.meta.dirname}/translations/en-US.ftl`, "utf-8");
169159
const resource = new FluentResource(ftl);
170160
const bundle = new FluentBundle("en-US");
171161
bundle.addResource(resource);
@@ -174,37 +164,24 @@ const getMessage = await (async function () {
174164
const conjunction = new Intl.ListFormat("en-US", { type: "conjunction" });
175165

176166
return (messageId, messageParams) => {
177-
messageParams = messageParams ?? {};
178167
for (const paramId in messageParams) {
179168
if (typeof messageParams[paramId] === "object") {
180169
if ("or" in messageParams[paramId]) {
181-
messageParams[paramId] = disjunction.format(
182-
messageParams[paramId].or
183-
);
170+
messageParams[paramId] = disjunction.format(messageParams[paramId].or);
184171
} else {
185172
messageParams[paramId] = conjunction.format(messageParams[paramId].and);
186173
}
187174
}
188175
}
176+
189177
const message = bundle.getMessage(messageId);
190178
if (!message?.value) {
191179
throw Error(`Message '${messageId}' not found.`);
192180
}
193-
if ("maximum" in messageParams && !("exclusiveMaximum" in messageParams)) {
194-
messageParams.exclusiveMaximum = messageParams.maximum;
195-
}
196-
if ("exclusiveMaximum" in messageParams && !("maximum" in messageParams)) {
197-
messageParams.maximum = messageParams.exclusiveMaximum;
198-
}
199-
if ("minimum" in messageParams && !("exclusiveMinimum" in messageParams)) {
200-
messageParams.exclusiveMinimum = messageParams.minimum;
201-
}
202-
if ("exclusiveMinimum" in messageParams && !("minimum" in messageParams)) {
203-
messageParams.minimum = messageParams.exclusiveMinimum;
204-
}
181+
205182
return bundle.formatPattern(message.value, messageParams);
206183
};
207-
})();
184+
}());
208185

209186
runTests("https://json-schema.org/draft/2020-12/schema", 2020);
210187
runTests("https://json-schema.org/draft/2019-09/schema", 2019);

src/index.js

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,14 @@ import dependentSchemasNormalizationHandler from "./normalization-handlers/depen
1717
import dynamicRefNormalizationHandler from "./normalization-handlers/dynamicRef.js";
1818
import elseNormalizationHandler from "./normalization-handlers/else.js";
1919
import enumNormalizationHandler from "./normalization-handlers/enum.js";
20-
// import exclusiveMaximumDraft04NormalizationHandler from "./normalization-handlers/draft-04/exclusiveMaximum.js";
21-
// import exclusiveMaximumNormalizationHandler from "./normalization-handlers/exclusiveMaximum.js";
22-
// import exclusiveMinimumDraft04NormalizationHandler from "./normalization-handlers/draft-04/exclusiveMinimum.js";
23-
// import exclusiveMinimumNormalizationHandler from "./normalization-handlers/exclusiveMinimum.js";
2420
import formatNormalizationHandler from "./normalization-handlers/format.js";
2521
import ifNormalizationHandler from "./normalization-handlers/if.js";
2622
import itemsDraft04NormalizationHandler from "./normalization-handlers/draft-04/items.js";
2723
import itemsNormalizationHandler from "./normalization-handlers/items.js";
28-
// import maximumDraft04NormalizationHandler from "./normalization-handlers/draft-04/maximum.js";
29-
// import maximumNormalizationHandler from "./normalization-handlers/maximum.js";
3024
import maxContainsNormalizationHandler from "./normalization-handlers/maxContains.js";
3125
import maxItemsNormalizationHandler from "./normalization-handlers/maxItems.js";
3226
import maxLengthNormalizationHandler from "./normalization-handlers/maxLength.js";
3327
import maxPropertiesNormalizationHandler from "./normalization-handlers/maxProperties.js";
34-
// import minimumDraft04NormalizationHandler from "./normalization-handlers/draft-04/minimum.js";
35-
// import minimumNormalizationHandler from "./normalization-handlers/minimum.js";
3628
import minContainsNormalizationHandler from "./normalization-handlers/minContains.js";
3729
import minItemsNormalizationHandler from "./normalization-handlers/minItems.js";
3830
import minLengthNormalizationHandler from "./normalization-handlers/minLength.js";
@@ -60,20 +52,12 @@ import booleanSchemaErrorHandler from "./error-handlers/boolean-schema.js";
6052
import constEnumErrorHandler from "./error-handlers/constEnum.js";
6153
import containsErrorHandler from "./error-handlers/contains.js";
6254
import dependenciesErrorHandler from "./error-handlers/draft-04/dependencies.js";
63-
import dependentRequiredErrorHandler from "./error-handlers/dependentRequired.js";
64-
import enumErrorHandler from "./error-handlers/enum.js";
65-
// import exclusiveMaximumErrorHandler from "./error-handlers/exclusiveMaximum.js";
66-
// import exclusiveMinimumErrorHandler from "./error-handlers/exclusiveMinimum.js";
6755
import formatErrorHandler from "./error-handlers/format.js";
6856
import combinedMaximumErrorHandler from "./error-handlers/combinedMaximum.js";
6957
import combinedMinimumErrorHandler from "./error-handlers/combinedMinimum.js";
70-
// import maximumDraft04ErrorHandler from "./error-handlers/draft-04/maximum.js";
71-
// import maximumErrorHandler from "./error-handlers/maximum.js";
7258
import maxItemsErrorHandler from "./error-handlers/maxItems.js";
7359
import maxLengthErrorHandler from "./error-handlers/maxLength.js";
7460
import maxPropertiesErrorHandler from "./error-handlers/maxProperties.js";
75-
// import minimumDraft04ErrorHandler from "./error-handlers/draft-04/minimum.js";
76-
// import minimumErrorHandler from "./error-handlers/minimum.js";
7761
import minItemsErrorHandler from "./error-handlers/minItems.js";
7862
import minLengthErrorHandler from "./error-handlers/minLength.js";
7963
import minPropertiesErrorHandler from "./error-handlers/minProperties.js";
@@ -118,18 +102,10 @@ setNormalizationHandler("https://json-schema.org/keyword/draft-04/format", forma
118102
setNormalizationHandler("https://json-schema.org/keyword/if", ifNormalizationHandler);
119103
setNormalizationHandler("https://json-schema.org/keyword/draft-04/items", itemsDraft04NormalizationHandler);
120104
setNormalizationHandler("https://json-schema.org/keyword/items", itemsNormalizationHandler);
121-
// setNormalizationHandler("https://json-schema.org/keyword/draft-04/exclusiveMaximum", exclusiveMaximumDraft04NormalizationHandler);
122-
// setNormalizationHandler("https://json-schema.org/keyword/exclusiveMaximum", exclusiveMaximumNormalizationHandler);
123-
// setNormalizationHandler("https://json-schema.org/keyword/draft-04/exclusiveMinimum", exclusiveMinimumDraft04NormalizationHandler);
124-
// setNormalizationHandler("https://json-schema.org/keyword/exclusiveMinimum", exclusiveMinimumNormalizationHandler);
125-
// setNormalizationHandler("https://json-schema.org/keyword/draft-04/maximum", maximumDraft04NormalizationHandler);
126-
// setNormalizationHandler("https://json-schema.org/keyword/maximum", maximumNormalizationHandler);
127105
setNormalizationHandler("https://json-schema.org/keyword/maxContains", maxContainsNormalizationHandler);
128106
setNormalizationHandler("https://json-schema.org/keyword/maxItems", maxItemsNormalizationHandler);
129107
setNormalizationHandler("https://json-schema.org/keyword/maxLength", maxLengthNormalizationHandler);
130108
setNormalizationHandler("https://json-schema.org/keyword/maxProperties", maxPropertiesNormalizationHandler);
131-
// setNormalizationHandler("https://json-schema.org/keyword/draft-04/minimum", minimumDraft04NormalizationHandler);
132-
// setNormalizationHandler("https://json-schema.org/keyword/minimum", minimumNormalizationHandler);
133109
setNormalizationHandler("https://json-schema.org/keyword/minContains", minContainsNormalizationHandler);
134110
setNormalizationHandler("https://json-schema.org/keyword/minItems", minItemsNormalizationHandler);
135111
setNormalizationHandler("https://json-schema.org/keyword/minLength", minLengthNormalizationHandler);
@@ -156,20 +132,12 @@ addErrorHandler(booleanSchemaErrorHandler);
156132
addErrorHandler(constEnumErrorHandler);
157133
addErrorHandler(containsErrorHandler);
158134
addErrorHandler(dependenciesErrorHandler);
159-
addErrorHandler(dependentRequiredErrorHandler);
160-
addErrorHandler(enumErrorHandler);
161-
// addErrorHandler(exclusiveMaximumErrorHandler);
162-
// addErrorHandler(exclusiveMinimumErrorHandler);
163135
addErrorHandler(formatErrorHandler);
164136
addErrorHandler(combinedMaximumErrorHandler);
165137
addErrorHandler(combinedMinimumErrorHandler);
166-
// addErrorHandler(maximumDraft04ErrorHandler);
167-
// addErrorHandler(maximumErrorHandler);
168138
addErrorHandler(maxItemsErrorHandler);
169139
addErrorHandler(maxLengthErrorHandler);
170140
addErrorHandler(maxPropertiesErrorHandler);
171-
// addErrorHandler(minimumDraft04ErrorHandler);
172-
// addErrorHandler(minimumErrorHandler);
173141
addErrorHandler(minItemsErrorHandler);
174142
addErrorHandler(minLengthErrorHandler);
175143
addErrorHandler(minPropertiesErrorHandler);

src/normalization-handlers/draft-04/exclusiveMaximum.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/normalization-handlers/draft-04/exclusiveMinimum.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)