-
Notifications
You must be signed in to change notification settings - Fork 308
fix(satp): Fix isFabricConfigJSON always printing error #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(satp): Fix isFabricConfigJSON always printing error #4004
Conversation
837c59f to
41eb943
Compare
...on/config-validating-functions/bridges-config-validating-functions/validate-fabric-config.ts
Outdated
Show resolved
Hide resolved
9cdcedc to
b420888
Compare
b420888 to
b047601
Compare
b047601 to
426d347
Compare
|
@Tomas-Silva2187 Thank you for the contribution. Can you please fix the commit name? It will fail in the commit linter (see https://github.com/hyperledger-cacti/cacti/actions/runs/18103706631/job/51512919716?pr=4004) |
426d347 to
f0e7982
Compare
It is now fixed |
9bee4bd to
1ae6a34
Compare
f0e7982 to
7901fd3
Compare
d30e3f3 to
0cddcca
Compare
...on/config-validating-functions/bridges-config-validating-functions/validate-fabric-config.ts
Outdated
Show resolved
Hide resolved
7fe81be to
be585be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
be585be to
628e7a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3ca7a62 to
11aa596
Compare
Signed-off-by: Tomás Silva <[email protected]>
11aa596 to
61f9de8
Compare
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.