Skip to content

Conversation

@Tomas-Silva2187
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@Tomas-Silva2187 Tomas-Silva2187 force-pushed the fixGatewayErrors branch 2 times, most recently from 9cdcedc to b420888 Compare September 29, 2025 16:12
@Tomas-Silva2187 Tomas-Silva2187 changed the title Fix isFabricConfigJSON always throwing error on gateway fix(satp): Fix isFabricConfigJSON always throwing error on gateway Sep 29, 2025
@Tomas-Silva2187 Tomas-Silva2187 changed the title fix(satp): Fix isFabricConfigJSON always throwing error on gateway fix(satp): Fix isFabricConfigJSON always printing error Sep 29, 2025
@RafaelAPB
Copy link
Contributor

@Tomas-Silva2187 Thank you for the contribution. Can you please fix the commit name? It will fail in the commit linter (see https://github.com/hyperledger-cacti/cacti/actions/runs/18103706631/job/51512919716?pr=4004)

@Tomas-Silva2187
Copy link
Contributor Author

@Tomas-Silva2187 Thank you for the contribution. Can you please fix the commit name? It will fail in the commit linter (see https://github.com/hyperledger-cacti/cacti/actions/runs/18103706631/job/51512919716?pr=4004)

It is now fixed

@Tomas-Silva2187 Tomas-Silva2187 force-pushed the fixGatewayErrors branch 2 times, most recently from 7fe81be to be585be Compare October 14, 2025 01:29
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelAPB RafaelAPB self-requested a review October 18, 2025 18:01
@RafaelAPB RafaelAPB enabled auto-merge (rebase) October 20, 2025 18:42
@RafaelAPB RafaelAPB disabled auto-merge October 20, 2025 18:43
@RafaelAPB RafaelAPB added this to the SATP-Hermes v0.0.4-beta milestone Oct 20, 2025
@RafaelAPB RafaelAPB added the IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. label Oct 20, 2025
Copy link
Contributor

@AndreAugusto11 AndreAugusto11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tomas-Silva2187 Tomas-Silva2187 force-pushed the fixGatewayErrors branch 2 times, most recently from 3ca7a62 to 11aa596 Compare October 30, 2025 16:52
@RafaelAPB RafaelAPB enabled auto-merge (rebase) October 30, 2025 17:33
@RafaelAPB RafaelAPB merged commit dd99ce6 into hyperledger-cacti:main Oct 31, 2025
199 of 222 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants