Separate ScorexEncoding and ScorexLogging. Fix /pull/25#pullrequestreview-83719938

Author: catena2w

examples/src/main/scala/examples/commons/PublicKey25519NoncedBox.scala

@@ -6,7 +6,7 @@ import io.circe.syntax._
 import scorex.core.serialization.Serializer
 import scorex.core.transaction.account.PublicKeyNoncedBox
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.{ScorexEncoding, ScorexLogging}
 import scorex.crypto.encode.Base16
 import scorex.crypto.hash.Blake2b256
 import scorex.crypto.signatures.{Curve25519, PublicKey}
@@ -25,7 +25,7 @@ case class PublicKey25519NoncedBox(override val proposition: PublicKey25519Propo
     s"PublicKey25519NoncedBox(id: ${Base16.encode(id)}, proposition: $proposition, nonce: $nonce, value: $value)"
 }
 
-object PublicKey25519NoncedBox extends ScorexLogging {
+object PublicKey25519NoncedBox extends ScorexEncoding {
   val BoxKeyLength: Int = Blake2b256.DigestSize
   val BoxLength: Int = Curve25519.KeyLength + 2 * 8
 

examples/src/main/scala/examples/commons/SimpleBoxTransaction.scala

@@ -13,7 +13,7 @@ import scorex.core.transaction.box.BoxUnlocker
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
 import scorex.core.transaction.proof.{Proof, Signature25519}
 import scorex.core.transaction.state.{PrivateKey25519, PrivateKey25519Companion}
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.ScorexEncoding
 import scorex.crypto.hash.Blake2b256
 import scorex.crypto.signatures.{Curve25519, PublicKey, Signature}
 
@@ -73,7 +73,7 @@ case class SimpleBoxTransaction(from: IndexedSeq[(PublicKey25519Proposition, Non
 }
 
 
-object SimpleBoxTransaction extends ScorexLogging {
+object SimpleBoxTransaction extends ScorexEncoding {
 
   implicit val simpleBoxEncoder: Encoder[SimpleBoxTransaction] = (sbe: SimpleBoxTransaction) =>
     Map(

examples/src/main/scala/examples/hybrid/HybridNodeViewHolder.scala

@@ -12,7 +12,7 @@ import scorex.core.settings.ScorexSettings
 import scorex.core.transaction.Transaction
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
 import scorex.core.transaction.state.PrivateKey25519Companion
-import scorex.core.utils.{NetworkTimeProvider, ScorexLogging}
+import scorex.core.utils.{NetworkTimeProvider, ScorexEncoding, ScorexLogging}
 import scorex.core.{ModifierTypeId, NodeViewHolder, NodeViewModifier}
 import scorex.crypto.encode.Base58
 import scorex.crypto.signatures.PublicKey
@@ -65,7 +65,7 @@ class HybridNodeViewHolder(settings: ScorexSettings,
   }
 }
 
-object HybridNodeViewHolder extends ScorexLogging {
+object HybridNodeViewHolder extends ScorexLogging with ScorexEncoding {
   def generateGenesisState(settings: ScorexSettings, minerSettings: HybridMiningSettings, timeProvider: NetworkTimeProvider):
                           (HybridHistory, HBoxStoredState, HBoxWallet, SimpleBoxTransactionMemPool) = {
     val GenesisAccountsNum = 50

examples/src/main/scala/examples/hybrid/api/http/DebugApiRoute.scala

@@ -11,15 +11,15 @@ import io.circe.syntax._
 import scorex.core.ModifierId
 import scorex.core.api.http.{ApiResponse, ApiRouteWithFullView}
 import scorex.core.settings.RESTApiSettings
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.{ScorexEncoding, ScorexLogging}
 
 import scala.util.Try
 
 
 case class DebugApiRoute(override val settings: RESTApiSettings, nodeViewHolderRef: ActorRef)
                         (implicit val context: ActorRefFactory)
   extends ApiRouteWithFullView[HybridHistory, HBoxStoredState, HBoxWallet, SimpleBoxTransactionMemPool] 
-    with ScorexLogging {
+    with ScorexEncoding {
 
   override val route: Route = (pathPrefix("debug") & withCors) {
     infoRoute ~ chain ~ delay ~ myblocks ~ generators

examples/src/main/scala/examples/hybrid/api/http/StatsApiRoute.scala

@@ -10,14 +10,14 @@ import io.circe.syntax._
 import scorex.core.ModifierId
 import scorex.core.api.http.{ApiResponse, ApiRouteWithFullView, ApiTry}
 import scorex.core.settings.RESTApiSettings
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.{ScorexEncoding, ScorexLogging}
 
 import scala.util.Try
 
 case class StatsApiRoute(override val settings: RESTApiSettings, nodeViewHolderRef: ActorRef)
                         (implicit val context: ActorRefFactory)
   extends ApiRouteWithFullView[HybridHistory, HBoxStoredState, HBoxWallet, SimpleBoxTransactionMemPool]
-    with ScorexLogging {
+    with ScorexEncoding {
 
   override val route: Route = (pathPrefix("stats") & withCors) {
     tail ~ meanDifficulty

examples/src/main/scala/examples/hybrid/api/http/WalletApiRoute.scala

@@ -11,8 +11,7 @@ import io.circe.syntax._
 import scorex.core.api.http.{ApiError, ApiResponse, ApiRouteWithFullView}
 import scorex.core.settings.RESTApiSettings
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
-import scorex.core.utils.ScorexLogging
-import scorex.crypto.encode.Base58
+import scorex.core.utils.ScorexEncoding
 import scorex.crypto.signatures.PublicKey
 
 import scala.util.{Failure, Success, Try}
@@ -21,7 +20,7 @@ import scala.util.{Failure, Success, Try}
 case class WalletApiRoute(override val settings: RESTApiSettings, nodeViewHolderRef: ActorRef)
                          (implicit val context: ActorRefFactory)
   extends ApiRouteWithFullView[HybridHistory, HBoxStoredState, HBoxWallet, SimpleBoxTransactionMemPool]
-    with ScorexLogging {
+    with ScorexEncoding {
 
   import scorex.core.NodeViewHolder.ReceivableMessages.LocallyGeneratedTransaction
 

examples/src/main/scala/examples/hybrid/blocks/PosBlock.scala

@@ -9,7 +9,7 @@ import scorex.core.block.Block._
 import scorex.core.serialization.Serializer
 import scorex.core.transaction.proof.Signature25519
 import scorex.core.transaction.state.PrivateKey25519
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.{ScorexEncoding, ScorexLogging}
 import scorex.core.{ModifierId, ModifierTypeId, TransactionsCarryingPersistentNodeViewModifier}
 import scorex.crypto.hash.Blake2b256
 import scorex.crypto.signatures.{Curve25519, Signature}
@@ -38,7 +38,7 @@ case class PosBlock(override val parentId: BlockId, //PoW block
   override def toString: String = s"PoSBlock(${this.asJson.noSpaces})"
 }
 
-object PosBlockCompanion extends Serializer[PosBlock] with ScorexLogging {
+object PosBlockCompanion extends Serializer[PosBlock] with ScorexEncoding {
   override def toBytes(b: PosBlock): Array[Byte] = {
     val txsBytes = b.transactions.sortBy(t => encoder.encode(t.id)).foldLeft(Array[Byte]()) { (a, b) =>
       Bytes.concat(Ints.toByteArray(b.bytes.length), b.bytes, a)
@@ -77,7 +77,7 @@ object PosBlockCompanion extends Serializer[PosBlock] with ScorexLogging {
   }
 }
 
-object PosBlock extends ScorexLogging {
+object PosBlock extends ScorexEncoding {
   val MaxBlockSize = 512 * 1024 //512K
   val ModifierTypeId: ModifierTypeId = scorex.core.ModifierTypeId @@ 4.toByte
 

examples/src/main/scala/examples/hybrid/blocks/PowBlock.scala

@@ -5,12 +5,12 @@ import examples.commons.SimpleBoxTransaction
 import examples.hybrid.mining.HybridMiningSettings
 import io.circe.Encoder
 import io.circe.syntax._
-import scorex.core.{ModifierId, _}
 import scorex.core.block.Block
 import scorex.core.block.Block._
 import scorex.core.serialization.Serializer
 import scorex.core.transaction.box.proposition.{PublicKey25519Proposition, PublicKey25519PropositionSerializer}
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.ScorexEncoding
+import scorex.core.{ModifierId, _}
 import scorex.crypto.hash.Blake2b256
 import scorex.crypto.signatures.{Curve25519, PublicKey}
 
@@ -23,7 +23,7 @@ class PowBlockHeader(
                       val nonce: Long,
                       val brothersCount: Int,
                       val brothersHash: Array[Byte],
-                      val generatorProposition: PublicKey25519Proposition) extends ScorexLogging {
+                      val generatorProposition: PublicKey25519Proposition) extends ScorexEncoding {
 
 
   import PowBlockHeader._
@@ -135,7 +135,7 @@ object PowBlockCompanion extends Serializer[PowBlock] {
   }
 }
 
-object PowBlock extends ScorexLogging {
+object PowBlock extends ScorexEncoding {
   val ModifierTypeId: ModifierTypeId = scorex.core.ModifierTypeId @@ 3.toByte
 
   implicit val powBlockEncoder: Encoder[PowBlock] = (pb: PowBlock) => {

examples/src/main/scala/examples/hybrid/history/HybridHistory.scala

@@ -14,10 +14,9 @@ import scorex.core.consensus.ModifierSemanticValidity._
 import scorex.core.consensus._
 import scorex.core.settings.ScorexSettings
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
-import scorex.core.utils.{NetworkTimeProvider, ScorexLogging}
-import scorex.core.validation.{MalformedModifierError, RecoverableModifierError}
+import scorex.core.utils.{NetworkTimeProvider, ScorexEncoding, ScorexLogging}
+import scorex.core.validation.RecoverableModifierError
 import scorex.core.{ModifierId, ModifierTypeId, NodeViewModifier}
-import scorex.crypto.encode.Base58
 import scorex.crypto.hash.Blake2b256
 
 import scala.annotation.tailrec
@@ -32,7 +31,7 @@ class HybridHistory(val storage: HistoryStorage,
                     validators: Seq[BlockValidator[HybridBlock]],
                     statsLogger: Option[FileLogger],
                     timeProvider: NetworkTimeProvider)
-  extends History[HybridBlock, HybridSyncInfo, HybridHistory] with ScorexLogging {
+  extends History[HybridBlock, HybridSyncInfo, HybridHistory] with ScorexLogging with ScorexEncoding {
 
   import HybridHistory._
 
@@ -204,7 +203,7 @@ class HybridHistory(val storage: HistoryStorage,
 
     val newSuffixValid = !newSuffix.drop(1).map(storage.semanticValidity).contains(Invalid)
 
-    if(newSuffixValid) {
+    if (newSuffixValid) {
       // TODO: fixme, What should we do if `oldSuffix` is empty? and .get
       @SuppressWarnings(Array("org.wartremover.warts.TraversableOps", "org.wartremover.warts.OptionPartial"))
       val throwBlocks = oldSuffix.tail.map(id => modifierById(id).get)
@@ -463,7 +462,7 @@ class HybridHistory(val storage: HistoryStorage,
     * Average delay in milliseconds between last $blockNum blocks starting from $block
     * Debug only
     */
-  @SuppressWarnings(Array("org.wartremover.warts.TraversableOps","org.wartremover.warts.OptionPartial"))
+  @SuppressWarnings(Array("org.wartremover.warts.TraversableOps", "org.wartremover.warts.OptionPartial"))
   def averageDelay(id: ModifierId, blockNum: Int): Try[Long] = Try {
     val block = modifierById(id).get
     val c = chainBack(block, isGenesis, blockNum).get.map(_._2)
@@ -486,7 +485,7 @@ class HybridHistory(val storage: HistoryStorage,
 
   override def reportModifierIsInvalid(modifier: HybridBlock,
                                        progressInfo: ProgressInfo[HybridBlock]): (HybridHistory,
-                                                                                  ProgressInfo[HybridBlock]) = {
+    ProgressInfo[HybridBlock]) = {
     storage.updateValidity(modifier, Invalid)
 
     new HybridHistory(storage, settings, validators, statsLogger, timeProvider) ->

examples/src/main/scala/examples/hybrid/mining/PowMiner.scala

@@ -11,7 +11,7 @@ import scorex.core.ModifierId
 import scorex.core.NodeViewHolder.CurrentView
 import scorex.core.block.Block.BlockId
 import scorex.core.transaction.box.proposition.PublicKey25519Proposition
-import scorex.core.utils.ScorexLogging
+import scorex.core.utils.{ScorexEncoding, ScorexLogging}
 import scorex.crypto.encode.Base58
 import scorex.crypto.hash.Blake2b256
 
@@ -25,7 +25,7 @@ import scala.util.Random
   * and stops on a new PoW block found (when PoS ref is unknown)
   */
 class PowMiner(viewHolderRef: ActorRef, settings: HybridMiningSettings)(implicit ec: ExecutionContext)
-  extends Actor with ScorexLogging {
+  extends Actor with ScorexLogging with ScorexEncoding {
 
   import PowMiner.ReceivableMessages._
   import PowMiner._