Removing const from the recent getRelatedToMaxWeightAndObject methods

[dudarboh]

Could we remove const from the returned EVENT::LCObject*? I.e. change

LCIO/src/cpp/include/UTIL/LCRelationNavigator.h

Line 94 in 5c0e330

std::tuple<float, const EVENT::LCObject*> getRelatedToMaxWeightAndObject(EVENT::LCObject* from, DecodeF&& decode = identity ) const{

LCIO/src/cpp/include/UTIL/LCRelationNavigator.h

Line 132 in 5c0e330

const EVENT::LCObject* getRelatedToMaxWeightObject(EVENT::LCObject* from, DecodeF&& decode = identity ) const{

LCIO/src/cpp/include/UTIL/LCRelationNavigator.h

Line 146 in 5c0e330

const EVENT::LCObject* getRelatedFromMaxWeightObject(EVENT::LCObject* to, DecodeF&& decode = identity ) const{

to

 std::tuple<float, EVENT::LCObject*> getRelatedToMaxWeightAndObject(EVENT::LCObject* from, DecodeF&& decode = identity ) const{ 

 EVENT::LCObject* getRelatedToMaxWeightObject(EVENT::LCObject* from, DecodeF&& decode = identity ) const{ 

 EVENT::LCObject* getRelatedFromMaxWeightObject(EVENT::LCObject* to, DecodeF&& decode = identity ) const{ 

Before these methods one previously used getRelatedToObjects() / getRelatedFromObjects() which returned const std::vector<EVENT::LCObject*>. Objects were not const.

Could we keep things consistent with the previous usage and keep it non-const?
Otherwise, I have to change my all functions to using e.g const MCParticle* instead of MCParticle* or copy object behind the pointer...

EVENT::LCCollection::getElementAt() gets objects from collection also without const.

And we have impl classes with setters, so const is somewhat redundant here if I am not missing anything...

[tmadlener]

I see where #204 is going now.

Just to point this out: since all the Impl objects derive from LCObject, there is nothing from preventing you from simply casting, e.g. a MCParticle* to a MCParticleImpl* and get your setters back. However, that is a design decision too far in the past to retrofit const-correctness now probably.