Skip to content

Unique ID for simulation events #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlincett opened this issue Oct 19, 2023 · 0 comments
Open

Unique ID for simulation events #12

mlincett opened this issue Oct 19, 2023 · 0 comments

Comments

@mlincett
Copy link
Contributor

In the discussion of #7 , @tianluyuan raised the concern about run_id and event_id not being unique for simulated events in the input file.

It is to be noted that the current i3_to_json.py functionality does not fully support the case of multiple events with same run_id and event_id. It is then out of scope of PR #7 to address this issue.

We currently still need a unique (run_id, event_id) for SkyDriver as well.

So either:

  • the user makes sure that run_id and event_id are unique and properly defined in the input data;
  • skywriter must find a way to map each simulated event to a unique run_id and event_id combination;
  • SkyDriver implements an unique id that is not based on (run_id, event_id), but this becomes increasingly inconvenient for the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant