Skip to content

[i3_to_json] harmonize extra particle extraction #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
mlincett opened this issue Oct 24, 2023 · 0 comments
Open
2 tasks

[i3_to_json] harmonize extra particle extraction #17

mlincett opened this issue Oct 24, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mlincett
Copy link
Contributor

mlincett commented Oct 24, 2023

Quoting from the current README (following #15):

It is not possible to copy an arbitrary key/object from the input P-frame to the output P-frame. There is also no warranty that a particle extracted with the --extra option will have a corresponding object in the output P-frame. If you need such a feature, or you want to improve this behavior, feel free to file a pull request!

Ideally:

  • it should be possible to write out arbitrary keys even if they are not I3Particle objects;
  • all objects corresponding to I3Particle-s extracted with --extra should be written in the output P frame.

None of these should be particularly hard to implement but I did not want to further delay the merge of #15

@mlincett mlincett added enhancement New feature or request good first issue Good for newcomers labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant