Skip to content

Commit f9fd765

Browse files
Green: Use project references to avoid reference conversion issue
The previous issue was that copying metadata references directly between compilations wasn't working for `CompilationReference`s. Originally I thought it was only possible to reference a compilation of the same type, and hence copying references wouldn't work, but now I suspect it just needs an accompanying project reference
1 parent da88128 commit f9fd765

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ICSharpCode.CodeConverter/Shared/ProjectConversion.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public static IEnumerable<ConversionResult> ConvertProjectContents(Project proje
7272
var solutionFilePath = project.Solution.FilePath;
7373
var solutionDir = Path.GetDirectoryName(solutionFilePath);
7474
var compilation = project.GetCompilationAsync().GetAwaiter().GetResult();
75-
var projectConversion = new ProjectConversion(compilation, solutionDir, languageConversion, GetConvertedCompilation(project.GetCompilationAsync().GetAwaiter().GetResult(), languageConversion));
75+
var projectConversion = new ProjectConversion(compilation, solutionDir, languageConversion, GetConvertedCompilationWithProjectReferences(project, languageConversion));
7676
foreach (var conversionResult in ConvertProjectContents(projectConversion)) yield return conversionResult;
7777
}
7878

0 commit comments

Comments
 (0)