Skip to content

Commit b96c7f5

Browse files
committed
reproduce shared dependencies issue
1 parent 3943a5b commit b96c7f5

File tree

8 files changed

+283
-174
lines changed

8 files changed

+283
-174
lines changed

.gitignore

+3-1
Original file line numberDiff line numberDiff line change
@@ -150,4 +150,6 @@ cdk.out/
150150
.nx/cache/*
151151
.yalc
152152
yalc.lock
153-
.swc
153+
.swc
154+
155+
static/*

apps/mfe-remote-1/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"react-router-dom": "^6.11.2",
1313
"react-error-boundary": "^4.0.9",
1414
"react-helmet-async": "^1.3.0",
15-
"external-package-version-display": "1.0.1"
15+
"external-package-version-display": "1.0.1",
16+
"external-package-version-display-2": "1.0.0"
1617
},
1718
"devDependencies": {
1819
"@rspack/plugin-node-polyfill": "^0.5.8",

apps/mfe-remote-1/remotes/mfe-remote-1-child-1/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"react-router-dom": "^6.11.2",
1313
"react-error-boundary": "^4.0.9",
1414
"react-helmet-async": "^1.3.0",
15-
"external-package-version-display": "1.1.0"
15+
"external-package-version-display": "2.1.4",
16+
"external-package-version-display-2": "1.0.1"
1617
},
1718
"devDependencies": {
1819
"@rspack/plugin-node-polyfill": "^0.5.8",

apps/mfe-remote-1/remotes/mfe-remote-1-child-1/src/routes/index.tsx

+12-10
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@ import { AppProviders } from "../components/AppProviders";
33
import { NavigationManager } from "../components/NavigationManager";
44
import { Box } from "@mui/material";
55
import { VersionDisplay } from "external-package-version-display";
6+
import { VersionDisplay as VersionDisplay2 } from "external-package-version-display-2";
67
import React from "react";
7-
const ExternalMFERemote2Component = React.lazy(
8-
() => import("mfe-remote-2/ExternalMFERemote2Component"),
9-
);
10-
const ExternalZMFERemote3Component = React.lazy(
11-
() => import("z-mfe-remote-3/ExternalZMFERemote3Component"),
12-
);
13-
8+
// const ExternalMFERemote2Component = React.lazy(
9+
// () => import("mfe-remote-2/ExternalMFERemote2Component"),
10+
// );
11+
// const ExternalZMFERemote3Component = React.lazy(
12+
// () => import("z-mfe-remote-3/ExternalZMFERemote3Component"),
13+
// );
14+
// console.log("mfe-remote-1-child-1 mui version", version, version === "5.15.2");
1415
export const routes = (
1516
shellRoutingPrefix?: string,
1617
appRoutingPrefix?: string,
@@ -36,10 +37,11 @@ export const routes = (
3637
element: (
3738
<Box>
3839
<Box>MFE: mfe-remote-1-child-1</Box>
39-
external-package-version-display Required Version: 1.1.0
40+
external-package-version-display Required Version: 2.1.2
4041
<VersionDisplay />
41-
<ExternalZMFERemote3Component />
42-
<ExternalMFERemote2Component />
42+
<VersionDisplay2 />
43+
{/* <ExternalZMFERemote3Component />
44+
<ExternalMFERemote2Component /> */}
4345
</Box>
4446
),
4547
},

apps/mfe-remote-1/src/components/Layout/Layout.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { ErrorBoundary } from "@cnapp-ui/mfe-utils";
66
import { Sidebar } from "../Sidebar";
77
import { NavigationManager } from "../NavigationManager";
88
import { VersionDisplay } from "external-package-version-display";
9+
import { VersionDisplay as VersionDisplay2 } from "external-package-version-display-2";
910

1011
export const Layout = ({
1112
shellRoutingPrefix,
@@ -30,6 +31,7 @@ export const Layout = ({
3031
<Box>MFE: mfe-remote-1</Box>{" "}
3132
external-package-version-display Required Version: 1.0.1
3233
<VersionDisplay />
34+
<VersionDisplay2 />
3335
</Box>
3436
<Box sx={{ display: "flex" }}>
3537
<Sidebar />

apps/z-mfe-remote-3/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"react-router-dom": "^6.11.2",
1313
"react-error-boundary": "^4.0.9",
1414
"react-helmet-async": "^1.3.0",
15-
"external-package-version-display": "2.1.0"
15+
"external-package-version-display": "2.1.4",
16+
"external-package-version-display-2": "1.0.0"
1617
},
1718
"devDependencies": {
1819
"@rspack/plugin-node-polyfill": "^0.5.8",

apps/z-mfe-remote-3/src/routes/index.tsx

+8-5
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@ import { AppProviders } from "../components/AppProviders";
33
import { NavigationManager } from "../components/NavigationManager";
44
import { Box } from "@mui/material";
55
import { VersionDisplay } from "external-package-version-display";
6+
import { VersionDisplay as VersionDisplay2 } from "external-package-version-display-2";
7+
68
import React from "react";
7-
const ExternalMFERemote2Component = React.lazy(
8-
() => import("mfe-remote-2/ExternalMFERemote2Component"),
9-
);
9+
// const ExternalMFERemote2Component = React.lazy(
10+
// () => import("mfe-remote-2/ExternalMFERemote2Component"),
11+
// );
1012

1113
export const routes = (
1214
shellRoutingPrefix?: string,
@@ -29,10 +31,11 @@ export const routes = (
2931
index: true,
3032
element: (
3133
<Box>
32-
<Box>MFE: z-mfe-remote-2</Box>
34+
<Box>MFE: z-mfe-remote-3</Box>
3335
external-package-version-display Required Version: 2.1.0
3436
<VersionDisplay />
35-
<ExternalMFERemote2Component />
37+
<VersionDisplay2 />
38+
{/* <ExternalMFERemote2Component /> */}
3639
</Box>
3740
),
3841
},

0 commit comments

Comments
 (0)