This repository was archived by the owner on Jun 28, 2024. It is now read-only.
vectorized sample generation#6
Open
mixarcid wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks so much for your contribution @mixarcid. I am not maintaining this repository anymore and should have archived it a while ago (which I will do now). Thus, I will not be able to review and fully test your PR. If it won't be removed by the archival process automatically, I will simply leave it here, so interested users can use your variant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this repo! I've been using the Bingham distribution for my current project, and this has a very nice implementation of it.
Since I've been generating millions of samples from the Bingham distribution, I vectorized the
random_samplesfunction -- it's now about 300x times faster on my computer. Figured I'd create a PR in case you're interested!