Skip to content

Prevent overlapping checks #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssigwart wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Prevent overlapping checks #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions phpcs-server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ class PhpcsServer {
* @param document The text document on which validation started.
*/
private sendStartValidationNotification(document: TextDocument): void {
this.validating.set(document.uri, document);
this.connection.sendNotification(
proto.DidStartValidateTextDocumentNotification.type,
{ textDocument: TextDocumentIdentifier.create(document.uri) }
Expand All @@ -246,7 +245,6 @@ class PhpcsServer {
* @param document The text document on which validation ended.
*/
private sendEndValidationNotification(document: TextDocument): void {
this.validating.delete(document.uri);
this.connection.sendNotification(
proto.DidEndValidateTextDocumentNotification.type,
{ textDocument: TextDocumentIdentifier.create(document.uri) }
Expand All @@ -263,6 +261,7 @@ class PhpcsServer {
public async validateSingle(document: TextDocument): Promise<void> {
const { uri } = document;
if (this.validating.has(uri) === false) {
this.validating.set(uri, document);
let settings = await this.getDocumentSettings(document);
if (settings.enable) {
let diagnostics: Diagnostic[] = [];
Expand All @@ -273,9 +272,12 @@ class PhpcsServer {
} catch(error) {
throw new Error(this.getExceptionMessage(error, document));
} finally {
this.validating.delete(uri);
this.sendEndValidationNotification(document);
this.sendDiagnostics({ uri, diagnostics });
}
} else {
this.validating.delete(uri);
}
}
}
Expand Down