Skip to content

Commit e9f77bd

Browse files
committed
ci: stop running on Node 16
1 parent 2502a93 commit e9f77bd

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

.github/workflows/ci.yml

+4-10
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ jobs:
1414
strategy:
1515
matrix:
1616
node:
17-
- 16
1817
- 18
1918
- 20
2019
- 22
@@ -24,8 +23,6 @@ jobs:
2423
- macos-latest
2524
fail-fast: false
2625
runs-on: ${{ matrix.os }}
27-
env:
28-
YARN_IGNORE_NODE: 1
2926
steps:
3027
- uses: actions/checkout@v4
3128

@@ -38,17 +35,14 @@ jobs:
3835
- name: Install Dependencies
3936
run: yarn --immutable
4037

41-
- name: Build and Typecov
42-
run: yarn run-s build typecov
38+
- name: Build, Lint and Test
39+
run: |
40+
yarn build
41+
yarn run-p lint test typecov
4342
env:
4443
PARSER_NO_WATCH: true
4544

46-
- name: Lint and Test
47-
if: ${{ matrix.node != 16}}
48-
run: yarn run-s lint test
49-
5045
- name: Codecov
51-
if: ${{ matrix.node != 16}}
5246
uses: codecov/codecov-action@v5
5347
with:
5448
token: ${{ secrets.CODECOV_TOKEN }}

tests/e2e/e2e.spec.ts

+30-24
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ import path from 'node:path'
44
import { tryFile } from '@pkgr/core'
55
import { exec } from 'tinyexec'
66

7+
const TIMEOUT = 30_000
8+
79
describe('e2e cases', async () => {
810
const { dirname } = import.meta
911

@@ -26,31 +28,35 @@ describe('e2e cases', async () => {
2628
})
2729
}
2830

29-
it('should exec eslint successfully', async () => {
30-
const eslintConfig = tryFile('eslint.config.js', false, absoluteDir)
31-
expect(
32-
await exec(
33-
'yarn',
34-
[
35-
'eslint',
36-
...(eslintConfig
37-
? ['-c', eslintConfig]
38-
: ['--ignore-pattern', '!.dot']),
39-
'--ext',
40-
'cjs,cts,js,jsx,mjs,mts,ts,tsx',
41-
'--report-unused-disable-directives',
42-
absoluteDir,
43-
],
44-
{
45-
nodeOptions: {
46-
env: {
47-
ESLINT_USE_FLAT_CONFIG: eslintConfig ? undefined : 'false',
48-
NODE_OPTIONS: '--no-warnings=ESLintRCWarning',
31+
it(
32+
`should exec eslint successfully > ${dirName}`,
33+
async () => {
34+
const eslintConfig = tryFile('eslint.config.js', false, absoluteDir)
35+
expect(
36+
await exec(
37+
'yarn',
38+
[
39+
'eslint',
40+
...(eslintConfig
41+
? ['-c', eslintConfig]
42+
: ['--ignore-pattern', '!.dot']),
43+
'--ext',
44+
'cjs,cts,js,jsx,mjs,mts,ts,tsx',
45+
'--report-unused-disable-directives',
46+
absoluteDir,
47+
],
48+
{
49+
nodeOptions: {
50+
env: {
51+
ESLINT_USE_FLAT_CONFIG: eslintConfig ? undefined : 'false',
52+
NODE_OPTIONS: '--no-warnings=ESLintRCWarning',
53+
},
4954
},
5055
},
51-
},
52-
),
53-
).toMatchSnapshot(dirName)
54-
})
56+
),
57+
).toMatchSnapshot()
58+
},
59+
TIMEOUT,
60+
)
5561
}
5662
})

0 commit comments

Comments
 (0)