Broken imports from @uidotdev/usehooks after upgrading to v3.9.0 or later

[Brandon-Ritchie]

Upgrading from version 3.8.3 to 4.3.4 and I am getting errors that there are pretty much no exports availaboe from @uidotdev/usehooks.

The breaking change seems to be with version 3.9.0, when there was a migration between resolvers.

Here is my tsconfig (if that is helpful):

{
    "compilerOptions": {
        "target": "ES2020",
        "useDefineForClassFields": true,
        "lib": ["ES2020", "DOM", "DOM.Iterable"],
        "module": "ESNext",
        "skipLibCheck": true,

        /* Bundler mode */
        "moduleResolution": "bundler",
        "allowImportingTsExtensions": true,
        "resolveJsonModule": true,
        "isolatedModules": true,
        "noEmit": true,
        "jsx": "react-jsx",

        /* Linting */
        "strict": true,
        "noUnusedLocals": true,
        "noUnusedParameters": true,
        "noFallthroughCasesInSwitch": true
    },
    "include": ["src"],
    "references": [{ "path": "./tsconfig.node.json" }]
}

And here is the relevant part of my eslint config:

import importPlugin from "eslint-plugin-import";

...
{
    ...

    importPlugin.flatConfigs.recommended,
    {
        rules: {
            "import/first": "error",
            "import/no-amd": "error",
            "import/no-anonymous-default-export": "error",
        },
        settings: {
            "import/parsers": {
                "@typescript-eslint/parser": [".ts", ".tsx"],
            },
            "import/resolver": {
                typescript: {
                    alwaysTryTypes: true,
                    project: "./tsconfig.json"
                },
            },
        },
    },

    ...
}

[JounQin]

Please provide a minimal but runnable reproduction.

[Brandon-Ritchie]

@JounQin here is a repository that shows the issue: https://github.com/Brandon-Ritchie/eslint-import-reproduction

[JounQin]

I seems to be related to unnecessary declare module "@uidotdev/usehooks" block in node_modules/@uidotdev/usehooks/index.d.ts, if you remove that, there will be no issue. I believe it's not related to this resolver, but of course it could be improved in eslint-plugin-import's side.

For eslint-import-resolver-typescript <3.9.0, it works because it fails to resolve types for @uidotdev/usehooks and then just fallback to index.js instead.

  eslint-import-resolver-typescript looking for @uidotdev/usehooks in /workspace/eslint-import-reproduction/src/useUIDotDev.ts +38ms
  eslint-import-resolver-typescript looking for @types/uidotdev__usehooks in /workspace/eslint-import-reproduction/src/useUIDotDev.ts +3ms
  eslint-import-resolver-typescript failed to resolve with @types/uidotdev__usehooks +2ms
  eslint-import-resolver-typescript didn't find  @types/uidotdev__usehooks +0ms
  eslint-import-resolver-typescript matched node path: /workspace/eslint-import-reproduction/node_modules/@uidotdev/usehooks/index.js +0ms

---

By the way, I'd suggest you to migrate to https://github.com/un-ts/eslint-plugin-import-x instead, see also un-ts/eslint-plugin-import-x#323 for more details. I'd like to transfer this issue to eslint-plugin-import-x instead because we could improve the parser to understand declare module "@uidotdev/usehooks", but we're in different organizations, would you mind close this one and raise it to eslint-plugin-import or eslint-plugin-import-x instead?

[Brandon-Ritchie]

Closing to open in eslint-plugin-import.

[Brandon-Ritchie]

Re-opening until I am able to confirm that I posted in the correct place.

[ljharb]

If there's an issue with TS resolution I'm not sure how it can be improved on the plugin side.

[JounQin]

If there's an issue with TS resolution I'm not sure how it can be improved on the plugin side.

@ljharb It's not about the resolution, but parsing .d.ts and recognize declare module 'xx' block.

[ljharb]

That's definitely something outside the purview of the plugin - it'd need to be in something TS-specific.

[JounQin]

@Brandon-Ritchie Let's close this issue then, I believe @ljharb agrees that we could improve how we handle this TypeScript case now: import-js/eslint-plugin-import#3186 (comment).