Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with --no-default-features -F async-std #103

Open
aqrln opened this issue Oct 17, 2024 · 0 comments
Open

Fix compilation with --no-default-features -F async-std #103

aqrln opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aqrln
Copy link
Collaborator

aqrln commented Oct 17, 2024

A Tokio semaphore is used unconditionally, so compilation fails with tokio feature disabled. This has been broken for 1 year and 8 months and no one complained, but it's possible that users who rely on async-std support just don't disable Tokio support. We should use something small and lightweight like https://github.com/smol-rs/async-lock instead when #![cfg(not(feature = "tokio"))].

@aqrln aqrln added the bug Something isn't working label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant