flake8 contrib and proto-tests (#689)

* flake8 contrib and proto-tests

* add to CI

Author: matthiasdiener

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
         -   name: "Main Script"
             run: |
                 curl -L -O https://gitlab.tiker.net/inducer/ci-support/raw/main/prepare-and-run-flake8.sh
-                . ./prepare-and-run-flake8.sh "$(basename $GITHUB_REPOSITORY)" ./test examples
+                . ./prepare-and-run-flake8.sh "$(basename $GITHUB_REPOSITORY)" ./test examples proto-tests contrib
 
     pylint:
         name: Pylint

contrib/c-integer-semantics.py

@@ -80,7 +80,7 @@ def main():
     with open("int-experiments.c", "w") as outf:
         outf.write(C_SRC)
 
-    system('gcc -Wall -shared int-experiments.c -o int-experiments.so')
+    system("gcc -Wall -shared int-experiments.c -o int-experiments.so")
 
     int_exp = ctypes.CDLL("int-experiments.so")
     for func in [

contrib/mem-pattern-explorer/pattern_vis.py

@@ -26,7 +26,7 @@ def __init__(self, gsize, lsize, subgroup_size=32, decay_constant=0.75):
 
         self.arrays = []
 
-    def l(self, index):  # noqa: E743
+    def l(self, index):  # noqa: E741,E743
         subscript = [np.newaxis] * self.ind_length
         subscript[len(self.gsize) + index] = slice(None)
 
@@ -125,7 +125,7 @@ def reshape_ind(ind):
             lin_index = np.array(lin_index)[subscript]
 
         self.array[lin_index, 0] = self.ctx.timestamp
-        for i, glength in enumerate(self.ctx.gsize):
+        for i, _glength in enumerate(self.ctx.gsize):
             if lin_index.shape[i] > 1:
                 self.array[lin_index, 2+i] = self.ctx.g(i)
 

doc/conf.py

@@ -1,7 +1,7 @@
 import os
 from urllib.request import urlopen
 
-_conf_url = "https://raw.githubusercontent.com/inducer/sphinxconfig/main/sphinxconfig.py"
+_conf_url = "https://raw.githubusercontent.com/inducer/sphinxconfig/main/sphinxconfig.py"  # noqa
 with urlopen(_conf_url) as _inf:
     exec(compile(_inf.read(), _conf_url, "exec"), globals())
 

proto-tests/test_fem_assembly.py

@@ -1,34 +1,32 @@
 import numpy as np
-import pyopencl as cl
+import pyopencl as cl  # noqa
 import loopy as lp
 
 from pyopencl.tools import pytest_generate_tests_for_pyopencl \
-        as pytest_generate_tests
-
-
+        as pytest_generate_tests  # noqa
 
 
 def test_laplacian_stiffness(ctx_factory):
     dtype = np.float32
     ctx = ctx_factory()
     order = "C"
 
-    dim = 2 # (baked into code)
+    dim = 2  # (baked into code)
 
-    Nq = 40 # num. quadrature points (baked into code)
-    Nb = 20 # num. basis functions (baked into code)
-    Nc = 100 # num. cells (run-time symbolic)
+    Nq = 40  # num. quadrature points (baked into code)  # noqa
+    Nb = 20  # num. basis functions (baked into code)  # noqa
+    Nc = 100  # num. cells (run-time symbolic)  # noqa
 
     from pymbolic import var
-    Nc_sym = var("Nc")
+    Nc_sym = var("Nc")  # noqa
 
     knl = lp.make_kernel(ctx.devices[0],
-            "[Nc] -> {[K,i,j,q, dx_axis, ax_b]: 0<=K<Nc and 0<=i,j<%(Nb)d and 0<=q<%(Nq)d "
+            "[Nc] -> {[K,i,j,q, dx_axis, ax_b]: 0<=K<Nc and 0<=i,j<%(Nb)d and 0<=q<%(Nq)d "  # noqa
             "and 0<= dx_axis, ax_b < %(dim)d}"
             % dict(Nb=Nb, Nq=Nq, dim=dim),
             [
                 "dPsi(ij, dxi) := sum_float32(@ax_b,"
-                    "  jacInv[ax_b,dxi,K,q] * DPsi[ax_b,ij,q])",
+                    "  jacInv[ax_b,dxi,K,q] * DPsi[ax_b,ij,q])",  # noqa
                 "A[K, i, j] = sum_float32(q, w[q] * jacDet[K,q] * ("
                     "sum_float32(dx_axis, dPsi$one(i,dx_axis)*dPsi$two(j,dx_axis))))"
                 ],
@@ -55,15 +53,15 @@ def variant_pg4(knl):
         # This (mostly) reproduces the unlabeled code snippet on pg. 4.
 
         knl = lp.tag_inames(knl, {"dx_axis": "unr"})
-        Ncloc = 16
+        Ncloc = 16  # noqa
         knl = lp.split_iname(knl, "K", Ncloc,
                 outer_iname="Ko", inner_iname="Kloc")
         return knl, ["Ko", "Kloc", "i", "j", "q", "ax_b_insn"]
 
     def variant_fig32(knl):
         # This (mostly) reproduces Figure 3.2.
 
-        Ncloc = 16
+        Ncloc = 16  # noqa
         knl = lp.split_iname(knl, "K", Ncloc,
                 outer_iname="Ko", inner_iname="Kloc")
         knl = lp.precompute(knl, "dPsi", np.float32, ["i", "q", "dx_axis"],
@@ -74,10 +72,10 @@ def variant_fig32(knl):
     def variant_fig33(knl):
         # This is meant to (mostly) reproduce Figure 3.3.
 
-        Ncloc = 16
+        Ncloc = 16  # noqa
         knl = lp.split_iname(knl, "K", Ncloc,
                 outer_iname="Ko", inner_iname="Kloc")
-        knl = lp.precompute(knl, "dPsi$one", np.float32, ["dx_axis"], default_tag=None)
+        knl = lp.precompute(knl, "dPsi$one", np.float32, ["dx_axis"], default_tag=None)  # noqa
         knl = lp.tag_inames(knl, {"j": "ilp.seq"})
 
         return knl, ["Ko", "Kloc"]
@@ -90,7 +88,7 @@ def variant_simple_gpu(knl):
         # help, too. :)
 
         knl = lp.tag_inames(knl, {"dx_axis": "unr"})
-        Ncloc = 16
+        Ncloc = 16  # noqa
         knl = lp.split_iname(knl, "K", Ncloc,
                 outer_iname="Ko", inner_iname="Kloc",
                 outer_tag="g.0")
@@ -105,7 +103,7 @@ def variant_simple_gpu_prefetch(knl):
         # fix that. (FIXME)
 
         knl = lp.tag_inames(knl, {"dx_axis": "unr"})
-        Ncloc = 16
+        Ncloc = 16  # noqa
         knl = lp.split_iname(knl, "K", Ncloc,
                 outer_iname="Ko", inner_iname="Kloc",
                 outer_tag="g.0")
@@ -132,13 +130,10 @@ def variant_simple_gpu_prefetch(knl):
                 parameters={"Nc": Nc}, print_ref_code=True)
 
 
-
-
 if __name__ == "__main__":
     import sys
     if len(sys.argv) > 1:
         exec(sys.argv[1])
     else:
         from py.test.cmdline import main
         main([__file__])
-