Skip to content

Commit b6942bd

Browse files
cowan-macadycowan-macady
committed
feat: remove bookmarks
implement ENG-5452
1 parent 821430a commit b6942bd

40 files changed

+1057
-1456
lines changed

‎Pipfile.lock

+414-424
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/config.html

+74-148
Large diffs are not rendered by default.

‎indykite_sdk/api_helper.py

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ def print_credential(credential): # pragma: no cover
1414
print("Agent config: " + str(credential.agent_config))
1515
elif hasattr(credential, 'service_account_config'):
1616
print("Service account config: " + str(credential.service_account_config))
17-
print("Bookmark: " + str(credential.bookmark))
1817
print("Create time: " + str(credential.create_time))
1918
print("Expire time: " + str(credential.expire_time))
2019

‎indykite_sdk/buf/validate/validate_pb2.py

+12-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎indykite_sdk/config/app_space.py

+11-23
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,18 @@
88
import indykite_sdk.utils.logger as logger
99

1010

11-
def read_app_space_by_id(self, app_space_id, bookmarks=[]):
11+
def read_app_space_by_id(self, app_space_id):
1212
"""
1313
get AppSpace object from id
1414
:param self:
1515
:param app_space_id: string gid id
16-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
1716
:return: AppSpace object
1817
"""
1918
sys.excepthook = logger.handle_excepthook
2019
try:
2120
response = self.stub.ReadApplicationSpace(
2221
pb2.ReadApplicationSpaceRequest(
23-
id=str(app_space_id),
24-
bookmarks=bookmarks
22+
id=str(app_space_id)
2523
)
2624
)
2725
except Exception as exception:
@@ -33,13 +31,12 @@ def read_app_space_by_id(self, app_space_id, bookmarks=[]):
3331
return ApplicationSpace.deserialize(response.app_space)
3432

3533

36-
def read_app_space_by_name(self, customer_id, app_space_name, bookmarks=[]):
34+
def read_app_space_by_name(self, customer_id, app_space_name):
3735
"""
3836
get AppSpace object from name
3937
:param self:
4038
:param customer_id: string gid id
4139
:param app_space_name: string
42-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
4340
:return: AppSpace object
4441
"""
4542
sys.excepthook = logger.handle_excepthook
@@ -49,8 +46,7 @@ def read_app_space_by_name(self, customer_id, app_space_name, bookmarks=[]):
4946
name=UniqueNameIdentifier(
5047
location=customer_id,
5148
name=app_space_name
52-
),
53-
bookmarks=bookmarks
49+
)
5450
)
5551
)
5652
except Exception as exception:
@@ -62,15 +58,14 @@ def read_app_space_by_name(self, customer_id, app_space_name, bookmarks=[]):
6258
return ApplicationSpace.deserialize(response.app_space)
6359

6460

65-
def create_app_space(self, customer_id, name, display_name, description="", bookmarks=[], region="europe-west1"):
61+
def create_app_space(self, customer_id, name, display_name, description="", region="europe-west1"):
6662
"""
6763
create new AppSpace
6864
:param self:
6965
:param customer_id: string gid id
7066
:param name: string pattern: ^[a-z](?:[-a-z0-9]{0,61}[a-z0-9])$
7167
:param display_name: string
7268
:param description: string
73-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
7469
:param region: in [europe-west1, us-east1]
7570
:return: deserialized CreateApplicationSpaceResponse
7671
"""
@@ -82,7 +77,6 @@ def create_app_space(self, customer_id, name, display_name, description="", book
8277
name=name,
8378
display_name=wrappers.StringValue(value=display_name),
8479
description=wrappers.StringValue(value=description),
85-
bookmarks=bookmarks,
8680
region=region
8781
)
8882
)
@@ -95,15 +89,14 @@ def create_app_space(self, customer_id, name, display_name, description="", book
9589
return CreateApplicationSpace.deserialize(response)
9690

9791

98-
def update_app_space(self, app_space_id, etag, display_name, description="", bookmarks=[]):
92+
def update_app_space(self, app_space_id, etag, display_name, description=""):
9993
"""
10094
update existing AppSpace
10195
:param self:
10296
:param app_space_id: string gid id
10397
:param etag: string
10498
:param display_name: string
10599
:param description: string
106-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
107100
:return: deserialized UpdateApplicationSpaceResponse
108101
"""
109102
sys.excepthook = logger.handle_excepthook
@@ -113,8 +106,7 @@ def update_app_space(self, app_space_id, etag, display_name, description="", boo
113106
id=app_space_id,
114107
etag=wrappers.StringValue(value=etag),
115108
display_name=wrappers.StringValue(value=display_name),
116-
description=wrappers.StringValue(value=description),
117-
bookmarks=bookmarks
109+
description=wrappers.StringValue(value=description)
118110
)
119111
)
120112
except Exception as exception:
@@ -126,22 +118,20 @@ def update_app_space(self, app_space_id, etag, display_name, description="", boo
126118
return UpdateApplicationSpace.deserialize(response)
127119

128120

129-
def list_app_spaces(self, customer_id, match=[], bookmarks=[]):
121+
def list_app_spaces(self, customer_id, match=[]):
130122
"""
131123
list AppSpaces which match exact name in match param
132124
:param self:
133125
:param customer_id: string gid id
134126
:param match: list of strings
135-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
136127
:return: ListApplicationSpacesResponse object
137128
"""
138129
sys.excepthook = logger.handle_excepthook
139130
try:
140131
streams = self.stub.ListApplicationSpaces(
141132
pb2.ListApplicationSpacesRequest(
142133
customer_id=customer_id,
143-
match=match,
144-
bookmarks=bookmarks
134+
match=match
145135
)
146136
)
147137
except Exception as exception:
@@ -157,22 +147,20 @@ def list_app_spaces(self, customer_id, match=[], bookmarks=[]):
157147
return logger.logger_error(exception)
158148

159149

160-
def delete_app_space(self, app_space_id, etag, bookmarks):
150+
def delete_app_space(self, app_space_id, etag):
161151
"""
162152
delete an AppSpace
163153
:param self:
164154
:param app_space_id: string gid id
165155
:param etag: string
166-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
167156
:return: DeleteApplicationSpaceResponse
168157
"""
169158
sys.excepthook = logger.handle_excepthook
170159
try:
171160
response = self.stub.DeleteApplicationSpace(
172161
pb2.DeleteApplicationSpaceRequest(
173162
id=app_space_id,
174-
etag=wrappers.StringValue(value=etag),
175-
bookmarks=bookmarks
163+
etag=wrappers.StringValue(value=etag)
176164
)
177165
)
178166
except Exception as exception:

‎indykite_sdk/config/application.py

+12-24
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,18 @@
88
import indykite_sdk.utils.logger as logger
99

1010

11-
def read_application_by_id(self, application_id, bookmarks=[]):
11+
def read_application_by_id(self, application_id):
1212
"""
1313
get an Application object with an id
1414
:param self:
1515
:param application_id: string gid id
16-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
1716
:return: Application object
1817
"""
1918
sys.excepthook = logger.handle_excepthook
2019
try:
2120
response = self.stub.ReadApplication(
2221
pb2.ReadApplicationRequest(
23-
id=str(application_id),
24-
bookmarks=bookmarks
22+
id=str(application_id)
2523
)
2624
)
2725
except Exception as exception:
@@ -33,13 +31,12 @@ def read_application_by_id(self, application_id, bookmarks=[]):
3331
return Application.deserialize(response.application)
3432

3533

36-
def read_application_by_name(self, app_space_id, application_name, bookmarks=[]):
34+
def read_application_by_name(self, app_space_id, application_name):
3735
"""
3836
get an Application object with a name
3937
:param self:
4038
:param app_space_id: string gid id
4139
:param application_name: string
42-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
4340
:return: Application object
4441
"""
4542
sys.excepthook = logger.handle_excepthook
@@ -49,8 +46,7 @@ def read_application_by_name(self, app_space_id, application_name, bookmarks=[])
4946
name=UniqueNameIdentifier(
5047
location=app_space_id,
5148
name=application_name
52-
),
53-
bookmarks=bookmarks
49+
)
5450
)
5551
)
5652
except Exception as exception:
@@ -62,15 +58,14 @@ def read_application_by_name(self, app_space_id, application_name, bookmarks=[])
6258
return Application.deserialize(response.application)
6359

6460

65-
def create_application(self, app_space_id, name, display_name, description="", bookmarks=[]):
61+
def create_application(self, app_space_id, name, display_name, description=""):
6662
"""
6763
create an Application
6864
:param self:
6965
:param app_space_id: string gid id
7066
:param name: string pattern: ^[a-z](?:[-a-z0-9]{0,61}[a-z0-9])$
7167
:param display_name: string
7268
:param description: string
73-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
7469
:return: deserialized CreateApplicationResponse
7570
"""
7671
sys.excepthook = logger.handle_excepthook
@@ -80,8 +75,7 @@ def create_application(self, app_space_id, name, display_name, description="", b
8075
app_space_id=app_space_id,
8176
name=name,
8277
display_name=wrappers.StringValue(value=display_name),
83-
description=wrappers.StringValue(value=description),
84-
bookmarks=bookmarks
78+
description=wrappers.StringValue(value=description)
8579
)
8680
)
8781
except Exception as exception:
@@ -93,15 +87,14 @@ def create_application(self, app_space_id, name, display_name, description="", b
9387
return CreateApplication.deserialize(response, app_space_id, name)
9488

9589

96-
def update_application(self, application_id, etag, display_name, description="", bookmarks=[]):
90+
def update_application(self, application_id, etag, display_name, description=""):
9791
"""
9892
update existing Application
9993
:param self:
10094
:param application_id: string gid id
10195
:param etag: string
10296
:param display_name: string
10397
:param description: string
104-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
10598
:return: deserialized UpdateApplicationResponse
10699
"""
107100
sys.excepthook = logger.handle_excepthook
@@ -111,8 +104,7 @@ def update_application(self, application_id, etag, display_name, description="",
111104
id=application_id,
112105
etag=wrappers.StringValue(value=etag),
113106
display_name=wrappers.StringValue(value=display_name),
114-
description=wrappers.StringValue(value=description),
115-
bookmarks=bookmarks
107+
description=wrappers.StringValue(value=description)
116108
)
117109
)
118110
except Exception as exception:
@@ -124,22 +116,20 @@ def update_application(self, application_id, etag, display_name, description="",
124116
return UpdateApplication.deserialize(response)
125117

126118

127-
def list_applications(self, app_space_id, match=[], bookmarks=[]):
119+
def list_applications(self, app_space_id, match=[]):
128120
"""
129121
list App which match exact name in match param
130122
:param self:
131123
:param app_space_id: string gid id
132124
:param match: list of strings
133-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
134125
:return: ListApplicationResponse object
135126
"""
136127
sys.excepthook = logger.handle_excepthook
137128
try:
138129
streams = self.stub.ListApplications(
139130
pb2.ListApplicationsRequest(
140131
app_space_id=app_space_id,
141-
match=match,
142-
bookmarks=bookmarks
132+
match=match
143133
)
144134
)
145135
except Exception as exception:
@@ -158,22 +148,20 @@ def list_applications(self, app_space_id, match=[], bookmarks=[]):
158148
return responses
159149

160150

161-
def delete_application(self, application_id, etag, bookmarks):
151+
def delete_application(self, application_id, etag):
162152
"""
163153
delete an application
164154
:param self:
165155
:param application_id: string gid id
166156
:param etag: string
167-
:param bookmarks: list of strings with pattern: ^[a-zA-Z0-9_-]{40,}$
168157
:return: DeleteApplicationResponse
169158
"""
170159
sys.excepthook = logger.handle_excepthook
171160
try:
172161
response = self.stub.DeleteApplication(
173162
pb2.DeleteApplicationRequest(
174163
id=application_id,
175-
etag=wrappers.StringValue(value=etag),
176-
bookmarks=bookmarks
164+
etag=wrappers.StringValue(value=etag)
177165
)
178166
)
179167
except Exception as exception:

0 commit comments

Comments
 (0)