added type annotations and __slots__ to the Python SDK #11394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also added __slots__ less so to improve efficiency and more to be sure there are no typos on assignments. There remain a few untyped parts where I could not find documentation of the types. These things are in particular: - Agent.Dsl - Agent.create_session() - DataSet.ParserConfig - I'm not sure if the documented parameters are complete. - Session.ask() - kwargs specific to agent/chat
dosubot
bot
added
size:XL
panzi
commented
Nov 19, 2025
| actual_keys = set(response.keys()) | ||
| if actual_keys == error_keys: | ||
| raise Exception(res.get("message")) | ||
| raise Exception(response.get("message")) |
Contributor
Author
There was a problem hiding this comment.
Noticed a bug here and fixed it while I was at it. Mentioned the bug here:
f007c1c#r170921731
panzi
commented
Nov 19, 2025
| answer = json_data["answer"] | ||
| reference = json_data.get("reference", {}) | ||
| else: | ||
| raise Exception(f"Unknown session type: {self.__session_type}") |
Contributor
Author
There was a problem hiding this comment.
Noticed a missing else branch and fixed it while I was at it. I mentioned that here:
95fad5d#r170922254
panzi
commented
Nov 20, 2025
| reference = json_data.get("reference", {}) | ||
| else: | ||
| raise Exception(f"Unknown session type: {self.__session_type}") | ||
| reference = json_data.get("reference") |
Contributor
Author
There was a problem hiding this comment.
Also I removed the default parameter to the get() method here. Creating an empty dict in any case here is useless overhead, especially since below there is an if reference ... anyway!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added
__slots__less so to improve efficiency and more to be sure there are no typos on assignments.There remain a few untyped parts where I could not find documentation of the types. These things are in particular:
Agent.DslAgent.create_session()DataSet.ParserConfig- I'm not sure if the documented parameters are complete.Session.ask()- kwargs specific to agent/chatWhat problem does this PR solve?
Type annotations are really handy for library consumers. They give you handy hints in your IDE and prevent typo bugs. The Python SDK is lacking type annotations, which is annoying at times.
Type of change
Added type annotations.