Skip to content

Conversation

@BingeCode
Copy link
Collaborator

Closes #5545

Changelog

See commit history

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

Visual Changes

Before

before.mov

After (Edit icon bigger, hover state and no layout shift on opened mini menu)

after.mov

Before
image

After (column title has more height)
image

@BingeCode BingeCode requested a review from Schwehn42 November 18, 2025 12:29
Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the MiniMenu is now bigger, the ColorPicker used also needs to be bigger

Image

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Nov 19, 2025
@BingeCode
Copy link
Collaborator Author

BingeCode commented Nov 20, 2025

since the MiniMenu is now bigger, the ColorPicker used also needs to be bigger

thanks for the notice, resolved with daad868

@BingeCode BingeCode removed the Changes Requested Changes requested by the reviewer label Nov 20, 2025
@BingeCode BingeCode requested a review from Schwehn42 November 20, 2025 09:53
@github-actions
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://5576.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-3fd921c

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-3fd921c

Copy link
Member

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍔

@BingeCode BingeCode added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit d323217 Nov 24, 2025
19 checks passed
@BingeCode BingeCode deleted the bs/edit-icon branch November 24, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change edit-icon (hovering over title+subtitle) on board

3 participants