feat: Disk resize #593

balcsida · 2025-08-25T12:26:56Z

This is still in progress, unpolished, vibecoded mess

.env

VirtualBuddy.xcodeproj/project.pbxproj.backup

balcsida · 2025-09-17T09:22:22Z

Thanks, @gabefair for the review comments!

Current status: Tested this with Tahoe VM, currently works with non-FileVault enabled disks, working on a way to make it work with FileVault enabled disks as well

giladgd · 2025-11-14T15:14:31Z

Any update about this? I've love to be able to resize the disk size of a macOS VM

VirtualCore/Source/Models/Configuration/VBManagedDiskImage+Resize.swift

VirtualCore/Source/Models/Configuration/ConfigurationModels.swift

balcsida · 2025-11-21T16:26:23Z

@giladgd Thanks for pinging me, I'll try to find some time to check on this tomorrow

tonyarnold · 2025-11-21T21:41:27Z

VirtualBuddy/Config/Signing.xcconfig

@@ -1,5 +1,5 @@
 CODE_SIGN_IDENTITY = Apple Development
-VB_BUNDLE_ID_PREFIX =
+VB_BUNDLE_ID_PREFIX = com.yourname.


This is an unnecessary change.

Suggested change

VB_BUNDLE_ID_PREFIX = com.yourname.

VB_BUNDLE_ID_PREFIX =

tonyarnold · 2025-11-21T21:44:00Z

VirtualBuddy.xcodeproj/project.pbxproj

-				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Mac Developer";
+				CODE_SIGN_IDENTITY = "Apple Development";
+				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"VirtualBuddy/Preview Content\"";
-				DEVELOPMENT_TEAM = 8C7439RJLG;
-				"DEVELOPMENT_TEAM[sdk=macosx*]" = 8C7439RJLG;
+				DEVELOPMENT_TEAM = "";
 				ENABLE_HARDENED_RUNTIME = YES;
 				ENABLE_PREVIEWS = YES;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_FILE = VirtualBuddy/Info.plist;
 				INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
 				INFOPLIST_KEY_NSHumanReadableCopyright = "© 2023 Buddy Software LTD";
 				INFOPLIST_KEY_NSMicrophoneUsageDescription = "Enable audio input for your virtual machines. Without this permission, virtual machines won't be able to record any audio.";
 				LD_RUNPATH_SEARCH_PATHS = "$(VB_APP_RUNPATH_SEARCH_PATHS)";
 				OTHER_LDFLAGS = "";
 				PRODUCT_BUNDLE_IDENTIFIER = "$(VB_BUNDLE_ID_PREFIX)codes.rambo.VirtualBuddy";
+				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 				SWIFT_VERSION = 5.0;
 			};
 			name = Beta_Debug;
 		};
 		F40A1E892C1869680033E47D /* Beta_Debug */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
 				CLANG_ENABLE_MODULES = YES;
 				CODE_SIGN_ENTITLEMENTS = VirtualBuddyGuest/VirtualBuddyGuest.entitlements;
+				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"VirtualBuddyGuest/Preview Content\"";
-				DEVELOPMENT_TEAM = 8C7439RJLG;
+				DEVELOPMENT_TEAM = "";


All of these changes need to be reverted.

tonyarnold · 2025-11-21T21:44:11Z

VirtualBuddy.xcodeproj/project.pbxproj

+				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
-				DEVELOPMENT_TEAM = 8C7439RJLG;
+				DEVELOPMENT_TEAM = "";


These too 😄

tonyarnold · 2025-11-21T21:44:31Z

VirtualBuddy.xcodeproj/project.pbxproj

-				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Mac Developer";
+				CODE_SIGN_IDENTITY = "Apple Development";
+				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"VirtualBuddy/Preview Content\"";
-				DEVELOPMENT_TEAM = 8C7439RJLG;
-				"DEVELOPMENT_TEAM[sdk=macosx*]" = 8C7439RJLG;
+				DEVELOPMENT_TEAM = "";
 				ENABLE_HARDENED_RUNTIME = YES;
 				ENABLE_PREVIEWS = YES;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_FILE = VirtualBuddy/Info.plist;
 				INFOPLIST_KEY_LSApplicationCategoryType = "public.app-category.developer-tools";
 				INFOPLIST_KEY_NSHumanReadableCopyright = "© 2023 Buddy Software LTD";
 				INFOPLIST_KEY_NSMicrophoneUsageDescription = "Enable audio input for your virtual machines. Without this permission, virtual machines won't be able to record any audio.";
 				LD_RUNPATH_SEARCH_PATHS = "$(VB_APP_RUNPATH_SEARCH_PATHS)";
 				OTHER_LDFLAGS = "";
 				PRODUCT_BUNDLE_IDENTIFIER = "$(VB_BUNDLE_ID_PREFIX)codes.rambo.VirtualBuddy";
+				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_EMIT_LOC_STRINGS = YES;
 				SWIFT_VERSION = 5.0;
 			};
 			name = Beta_Release;
 		};
 		F40A1E922C18697B0033E47D /* Beta_Release */ = {
 			isa = XCBuildConfiguration;
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
 				CLANG_ENABLE_MODULES = YES;
 				CODE_SIGN_ENTITLEMENTS = VirtualBuddyGuest/VirtualBuddyGuest.entitlements;
+				"CODE_SIGN_IDENTITY[sdk=macosx*]" = "-";
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
 				DEVELOPMENT_ASSET_PATHS = "\"VirtualBuddyGuest/Preview Content\"";
-				DEVELOPMENT_TEAM = 8C7439RJLG;
+				DEVELOPMENT_TEAM = "";
 				ENABLE_HARDENED_RUNTIME = YES;


And these 😅

You get the picture — all of the build config changes you've made need to be reverted before this could be merged.

Adding the files to the project is fine (although perhaps we should consider converting these to proper folders in a future PR).

balcsida · 2025-11-24T16:23:34Z

@giladgd, so sorry, but I barely had time to check this, and unfortunately, I run out of space on my machine to host VMs. I'm looking into some cheap solutions right now, thank you for your patience with me again!

- Add comprehensive disk image resizing support for RAW, DMG, and sparse image formats - Implement two resize strategies: in-place expansion and create-larger-image - Add robust error handling with detailed error messages - Include disk space validation and backup mechanisms - Support for both hdiutil and raw file operations

- Add canBeResized property for format compatibility checking - Add resize method with validation and error handling - Add displayName properties for better UI representation - Add resizeDisk method to VBStorageDevice for high-level operations

- Enable size editing for resizable existing disk images - Add resize confirmation dialog with detailed information - Show loading indicator during resize operations - Add informational messages for resizable disk formats - Handle resize errors with proper user feedback

- Add resize icon indicator for resizable disk images - Add context menu with resize option for storage devices - Fix canBeResized method to properly check disk image existence - Add remove device option to context menu for non-boot devices

- Add displayName property directly to VBManagedDiskImage.Format - Add canBeResized property directly to VBManagedDiskImage and VBStorageDevice - Fix method calls in ManagedDiskImageEditor to use proper disk image URL resolution - Simplify resize indicator checks in StorageConfigurationView

- Fix canBeResized to use pattern matching on backing property - Resolve 'managedImage' not in scope compilation error

- Remove direct VBDiskResizer call from UI to fix compilation - Add VBVirtualMachine+DiskResize extension for resize operations - Hook resize check into VMController.start() method - Show informational dialog when resize is scheduled - Handle resize operations automatically when VM starts

- Move checkAndResizeDiskImages to VBVirtualMachine+Metadata.swift - Remove separate VBVirtualMachine+DiskResize.swift file - Ensures methods are compiled with VirtualCore target - Resolves 'no member' compilation error

- Remove unnecessary guard let for non-optional configuration - Comment out VBDiskResizer call to avoid scope issues - Add TODO for actual resize implementation - Log resize requirement for future implementation

- Re-enable VBDiskResizer.resizeDiskImage call in VBVirtualMachine+Metadata.swift - Fix Timer-based slider confirmation to prevent popup spam - Add 0.5s delay before showing resize confirmation dialog - Complete disk resize feature implementation with actual system tools

- Fix temporary file creation in createRawImage function - Prevent FileHandle error for non-existent temporary files - Consolidate RAW image resize logic in createLargerImage - Properly handle file creation before ftruncate operations - Remove redundant createRawImage helper function call

…ators - Add expandPartitionsInDiskImage functionality to VBDiskResizer - Implement hdiutil attach/detach with diskutil resizeVolume for partition expansion - Add support for RAW, DMG, and Sparse image partition expansion - Add resizingDisk state to VMState enum with UI progress overlay - Update VirtualMachineSessionView to show resize progress indicator - Improve ManagedDiskImageEditor confirmation message - Add comprehensive logging for resize and partition operations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Add resizingDisk case to VirtualMachineControls.swift button state logic - Add resizingDisk case to VirtualMachineSessionView.swift state display logic - Ensure all VMState switch statements are exhaustive after adding new state - Both UI components now properly handle the disk resize progress state 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Skip Apple_APFS_ISC containers when finding resize target - Prioritize main Apple_APFS containers for partition expansion - Fixes issue where resize targeted small ISC container instead of main data container 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Detect when recovery partitions prevent main container expansion - Add specialized resize strategy for layouts with recovery partitions - Try multiple diskutil methods to handle partition repositioning - Fixes resize failure when recovery partition blocks container growth 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Acknowledge that recovery partitions may block immediate expansion - Provide clear logging about expected behavior for fresh macOS VMs - Focus on successful disk image resize rather than forced partition expansion - Recovery partitions in VM environments have complex layouts that may limit expansion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Attempt to delete recovery partition to allow main container expansion - Recovery partition will be recreated by macOS when needed - Fallback to boundary-aware resize if deletion fails - Better handling for established macOS installations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Add findRecoveryContainer to extract container reference from diskutil output - Use correct container identifier (e.g., disk6) instead of partition (disk4s3) - Add -force flag to deletion command for recovery containers - Better logging of container detection process 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Detect when recovery partition is protected by System Integrity Protection - Provide clear user guidance for manual partition adjustment - Acknowledge successful disk image resize even with partition limitations - Suggest Recovery Mode approach for full space utilization 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

…l apfs list

Co-authored-by: Tony Arnold <[email protected]>

balcsida · 2025-12-06T14:39:37Z

Thanks @tonyarnold for catching the accidentally modified project files and @giladgd for the patience 🙇
I gave up trying to implement enlarging FileVault enabled disks. However, VirtualBuddy will throw an error when trying to resize a FileVault enabled disk, asking the user to disable disk encryption:

tonyarnold · 2025-12-07T22:24:12Z

VirtualUI/Source/VM Configuration/Sections/Storage/StorageConfigurationView.swift

 }

 struct StorageDeviceListItem: View {
+    @EnvironmentObject var viewModel: VMConfigurationViewModel


Suggested change

@EnvironmentObject var viewModel: VMConfigurationViewModel

I don't think this is used anywhere in this View?

gabefair · 2025-12-08T03:45:34Z

Can you provide screenshots or a video of it working?

…

On Sun, Dec 7, 2025, 17:24 Tony Arnold ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In VirtualUI/Source/VM Configuration/Sections/Storage/StorageConfigurationView.swift <#593 (comment)> : > @@ -94,6 +109,7 @@ struct StorageConfigurationView: View { } struct StorageDeviceListItem: View { + @EnvironmentObject var viewModel: VMConfigurationViewModel ⬇️ Suggested change - @EnvironmentObject var viewModel: VMConfigurationViewModel I don't think this is used anywhere in this View? — Reply to this email directly, view it on GitHub <#593 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAP75EK6KO7MRFT2U6PJIN34ASSKHAVCNFSM6AAAAACEXVFR42VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNBZGY2TIMRTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

balcsida · 2025-12-08T13:37:52Z

Sure, here you go:

virtualbuddy_resize_disk.mp4

gabefair reviewed Sep 14, 2025

View reviewed changes

.env Outdated Show resolved Hide resolved

gabefair reviewed Sep 14, 2025

View reviewed changes

VirtualBuddy.xcodeproj/project.pbxproj.backup Outdated Show resolved Hide resolved

balcsida force-pushed the feat/disk-resize branch from 074ccc3 to 4a0c580 Compare September 16, 2025 16:07

tonyarnold reviewed Nov 20, 2025

View reviewed changes

VirtualCore/Source/Models/Configuration/VBManagedDiskImage+Resize.swift Outdated Show resolved Hide resolved

tonyarnold reviewed Nov 20, 2025

View reviewed changes

VirtualCore/Source/Models/Configuration/ConfigurationModels.swift Outdated Show resolved Hide resolved

tonyarnold reviewed Nov 21, 2025

View reviewed changes

balcsida force-pushed the feat/disk-resize branch from b38f02f to ae14dd2 Compare November 23, 2025 17:05

balcsida and others added 16 commits December 6, 2025 15:00

fix(storage): use proper pattern matching in canBeResized property

c89733e

- Fix canBeResized to use pattern matching on backing property - Resolve 'managedImage' not in scope compilation error

fix(build): move disk resize methods to existing extension file

4337e75

- Move checkAndResizeDiskImages to VBVirtualMachine+Metadata.swift - Remove separate VBVirtualMachine+DiskResize.swift file - Ensures methods are compiled with VirtualCore target - Resolves 'no member' compilation error

fix(build): resolve remaining compilation errors

c9b8d0a

- Remove unnecessary guard let for non-optional configuration - Comment out VBDiskResizer call to avoid scope issues - Add TODO for actual resize implementation - Log resize requirement for future implementation

balcsida and others added 12 commits December 6, 2025 15:00

fix(resize): properly detect and resize APFS containers using diskuti…

f745bfd

…l apfs list

fix(resize): optimize disk space usage for raw image resizing

35875b1

fix(resize): correct device name parsing for APFS container detection

524b263

feat(resize): add fallback strategies for VM disk APFS containers

fcf379d

fix: resolve compiler warnings for unused variables and unreachable code

5b6f85e

fix(ui): remove redundant disk resize alert

fc2be1e

feat(resize): surface detailed disk resize progress

30b0442

feat(resize): teach disk resizer about locked apfs volumes

f469291

fix(resize): use explicit selection logic for main APFS container

0375c21

balcsida force-pushed the feat/disk-resize branch from ae14dd2 to 0375c21 Compare December 6, 2025 14:00

balcsida and others added 6 commits December 6, 2025 15:17

feat(resize): add FileVault detection before disk resize

6f8b5ae

feat(resize): expose FileVault check for managed disk images

d63de25

feat(ui): block disk resize when FileVault is enabled

78d6c94

Apply suggestion from @tonyarnold

c83d3ae

Co-authored-by: Tony Arnold <[email protected]>

Apply suggestion from @tonyarnold

ee00a6a

Co-authored-by: Tony Arnold <[email protected]>

chore: restore accidentally modified project files

a190ebb

balcsida marked this pull request as ready for review December 6, 2025 14:36

balcsida requested review from gabefair and tonyarnold December 6, 2025 14:39

tonyarnold reviewed Dec 7, 2025

View reviewed changes

Uh oh!

feat: Disk resize #593

Are you sure you want to change the base?

feat: Disk resize #593

Uh oh!

Conversation

balcsida commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

balcsida commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

giladgd commented Nov 14, 2025

Uh oh!

Uh oh!

Uh oh!

balcsida commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonyarnold Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

tonyarnold Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

tonyarnold Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

tonyarnold Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

tonyarnold Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

balcsida commented Nov 24, 2025

Uh oh!

balcsida commented Dec 6, 2025

Uh oh!

tonyarnold Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gabefair commented Dec 8, 2025 via email

Uh oh!

balcsida commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

balcsida commented Sep 17, 2025 •

edited

Loading

balcsida commented Nov 21, 2025 •

edited

Loading

tonyarnold Dec 7, 2025 •

edited

Loading

balcsida commented Dec 8, 2025 •

edited

Loading