Skip to content

Some unit tests don't make sense #108

@j-refs

Description

@j-refs

Trawling thru the unit tests, I've noticed some failed tests that I really think should pass.
For example:
not ok 223 empty buffer and empty array are not equal
I, would honestly expect and empty buffer and empty array to NOT be equal. One holds arbitrary data and one holds bytes. So why then, are them not being equal a fail?
Also:
not ok 303 Date and RegExp are not equal
I cannot see any scenario where a Date and a RegExp would be any type of equal, them being 2 completely different types with completely different intended functionality. So then why is them not being equal a failed test?

I want to adopt this library, but I need to ensure I won't have any... Surprises.

Can someone explain these test results and maybe convince me to integrate this library?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions