Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate feature PR for potential merge #1323

Open
snova-rodrigom opened this issue Jan 28, 2025 · 3 comments
Open

Evaluate feature PR for potential merge #1323

snova-rodrigom opened this issue Jan 28, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@snova-rodrigom
Copy link

Is your feature request related to a problem? Please describe.
Not related to a problem but a request. We have a PR here that hasn't been evaluated yet and it's about integrating SambaNova. Could you please help us with that?

Describe the solution you'd like
Please, review PR above and let us know how we could help to merge it.

Describe alternatives you've considered
None

Additional context
We're trying to integrate SambaNova Cloud endpoints into Instructor, so devs could also have that possibility.

@github-actions github-actions bot added the enhancement New feature or request label Jan 28, 2025
@ivanleomk
Copy link
Collaborator

@snova-rodrigom sorry missed the PR, let me get on reviewing it now

@ivanleomk
Copy link
Collaborator

Hey @snova-rodrigom just looked at the PR and it seems like under the hood, it's using the OpenAI client to make the calls.

I don't think we should define a separate Samba Nova class in this instance since that just adds an additional layer of abstraction that will be difficult to maintain. People should just use the from_openai class in that case because that has a much richer layer of functionality too.

Would you be open instead to having a integrations page entry for samba nova?

@snova-rodrigom
Copy link
Author

hi @ivanleomk , yeah that'd be great. We may have a proper SDK soon, could you give me more details about the integrations page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants