Skip to content

fix(github_repository_file): delete error handling and codesigning #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(github_repository_file): delete error handling and codesigning #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01b47db
fix: improve error handling and define delete file options
ivanmartos Aug 20, 2025
c204c30
fix: update delete file message formatting in GitHub repository file …
ivanmartos Aug 20, 2025
ad479a3
fix: replace hardcoded random ID with dynamic generation in repositor…
ivanmartos Aug 20, 2025
85782b6
Merge branch 'main' into fix/deleteRepositoryFIle
nickfloyd Oct 21, 2025
4f7f45c
Merge branch 'main' into fix/deleteRepositoryFIle
nickfloyd Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions github/resource_github_repository_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,16 +460,14 @@

var branch string

message := fmt.Sprintf("Delete %s", file)

if commitMessage, hasCommitMessage := d.GetOk("commit_message"); hasCommitMessage {
message = commitMessage.(string)
opts, err := resourceGithubRepositoryFileOptions(d)
if err != nil {
return err
}

sha := d.Get("sha").(string)
opts := &github.RepositoryContentFileOptions{
Message: &message,
SHA: &sha,
if *opts.Message == fmt.Sprintf("Add %s", file) {
m := fmt.Sprintf("Delete %s", file)
opts.Message = &m
}

if b, ok := d.GetOk("branch"); ok {
Expand Down Expand Up @@ -503,7 +501,7 @@
opts.Branch = &branch
}

_, _, err := client.Repositories.DeleteFile(ctx, owner, repo, file, opts)

Check failure on line 504 in github/resource_github_repository_file.go

View workflow job for this annotation

GitHub Actions / ci 

no new variables on left side of :=

Check failure on line 504 in github/resource_github_repository_file.go

View workflow job for this annotation

GitHub Actions / ci 

no new variables on left side of :=) (typecheck)
return handleArchivedRepoDelete(err, "repository file", file, owner, repo)
}

Expand Down
10 changes: 4 additions & 6 deletions github/resource_github_repository_file_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@

func TestAccGithubRepositoryFile(t *testing.T) {

randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)

t.Run("creates and manages files", func(t *testing.T) {

config := fmt.Sprintf(`
Expand All @@ -33,7 +31,7 @@
commit_author = "Terraform User"
commit_email = "[email protected]"
}
`, randomID)
`, acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))
check := resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
"github_repository_file.test", "content",
Expand Down Expand Up @@ -111,7 +109,7 @@
commit_email = "[email protected]"
}

`, randomID)
`, acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))

check := resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
Expand Down Expand Up @@ -202,7 +200,7 @@
commit_author = "Terraform User"
commit_email = "[email protected]"
}
`, randomID)
`, acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))

check := resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
Expand Down Expand Up @@ -280,7 +278,7 @@
commit_email = "[email protected]"
autocreate_branch = false
}
`, randomID)
`, acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum))

check := resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
Expand Down Expand Up @@ -362,7 +360,7 @@
commit_author = "Terraform User"
commit_email = "[email protected]"
}
`, randomID)

Check failure on line 363 in github/resource_github_repository_file_test.go

View workflow job for this annotation

GitHub Actions / ci 

undefined: randomID

archivedConfig := strings.Replace(config,
`auto_init = true`,
Expand Down Expand Up @@ -401,7 +399,7 @@
auto_init = true
archived = true
}
`, randomID),

Check failure on line 402 in github/resource_github_repository_file_test.go

View workflow job for this annotation

GitHub Actions / ci 

undefined: randomID (typecheck)
},
},
})
Expand Down
Loading