Merge remote-tracking branch 'origin/main' into ib/dynamic_ivf

Author: ibhati

.github/workflows/skywalking-eyes.yml

@@ -34,7 +34,7 @@ jobs:
     runs-on: ubuntu-24.04
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
       - name: "Run check"
         uses: apache/skywalking-eyes/header@61275cc80d0798a405cb070f7d3a8aaf7cf2c2c1 # v0.8.0
         with:

include/svs/index/vamana/dynamic_search_buffer.h

@@ -498,6 +498,16 @@ template <typename Idx, typename Cmp = std::less<>> class MutableBuffer {
             }
         }
 
+        // TODO: Switch over to using iterators for the return values to avoid this.
+        // Maintain best_unvisited_ invariant
+        // cleanup() and std::sort() may invalidate best_unvisited_.
+        // so, have to lookup the next unvisited from scratch.
+        for (best_unvisited_ = 0; best_unvisited_ < roi_end_; ++best_unvisited_) {
+            if (!candidates_[best_unvisited_].visited()) {
+                break;
+            }
+        }
+
         // Check if invariant 6 is active.
         // If so, drop invalid elements off the end until a valid element is found.
         if (slack() == 0) {