[Autobackout][FuncReg]Revert of change: fc68e76

Rename `psHasSideEffect` field to `hasSideEffect` in SInstrTypes. The value is
valid for all stages.

Change-Id: I0f22d216e5b0cd11dc2e730b66648f6ddd9de0e3

Author: mmerecki

Diff for: IGC/Compiler/CISACodeGen/CheckInstrTypes.cpp

@@ -80,7 +80,7 @@ CheckInstrTypes::CheckInstrTypes(IGC::SInstrTypes* instrList) : FunctionPass(ID)
     instrList->hasReadOnlyArray = false;
     instrList->hasBuiltin = false;
     instrList->hasFRem = false;
-    instrList->hasSideEffect = false;
+    instrList->psHasSideEffect = false;
     instrList->hasDebugInfo = false;
     instrList->hasAtomics = false;
     instrList->hasBarrier = false;
@@ -193,7 +193,7 @@ void CheckInstrTypes::visitCallInst(CallInst& C)
             GenISAIntrinsic::ID IID = CI->getIntrinsicID();
             if (IID != GenISA_OUTPUT && IID != GenISA_discard)
             {
-                g_InstrTypes->hasSideEffect = true;
+                g_InstrTypes->psHasSideEffect = true;
             }
         }
     }
@@ -343,7 +343,7 @@ void CheckInstrTypes::visitStoreInst(StoreInst& I)
     uint as = I.getPointerAddressSpace();
     if (as != ADDRESS_SPACE_PRIVATE)
     {
-        g_InstrTypes->hasSideEffect = true;
+        g_InstrTypes->psHasSideEffect = true;
     }
     if (as == ADDRESS_SPACE_LOCAL)
     {

Diff for: IGC/Compiler/CodeGenPublic.h

@@ -251,7 +251,7 @@ namespace IGC
         bool hasReadOnlyArray;
         bool hasBuiltin;
         bool hasFRem;
-        bool hasSideEffect;     //<! shader writes to memory, does not include writing to shader outputs
+        bool psHasSideEffect;     //<! only relevant to pixel shader, has other memory writes besides RTWrite
         bool hasGenericAddressSpacePointers;
         bool hasDebugInfo;        //<! true only if module contains debug info !llvm.dbg.cu
         bool hasAtomics;

Diff for: IGC/Compiler/CustomSafeOptPass.cpp

@@ -130,7 +130,7 @@ STATISTIC(Stat_DiscardRemoved, "Number of insts removed in Discard Opt");
 
 bool CustomSafeOptPass::runOnFunction(Function& F)
 {
-    psHasSideEffect = getAnalysis<CodeGenContextWrapper>().getCodeGenContext()->m_instrTypes.hasSideEffect;
+    psHasSideEffect = getAnalysis<CodeGenContextWrapper>().getCodeGenContext()->m_instrTypes.psHasSideEffect;
     visit(F);
     return true;
 }