Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test coverage for DPAS layout block loads #3764

Closed
alexbaden opened this issue Mar 26, 2025 · 0 comments · Fixed by #3780
Closed

Improve unit test coverage for DPAS layout block loads #3764

alexbaden opened this issue Mar 26, 2025 · 0 comments · Fixed by #3780
Assignees

Comments

@alexbaden
Copy link
Contributor

While working on #3708 I encountered several places where changing the indices of the 2D block load resulted in incorrect results that were only caught by the benchmarking infrastructure - all the core tests, language tests, and lit tests passed. We should improve local test coverage so that these issues can be found and corrected on smaller problem sizes and without taking up benchmarking infrastructure. The plan for this issue is to write ttgir which loads using a 2D block load / DPAS layout and stores using a block layout. This will allow us to check just the loads without actually running DPAS/dot operations. By using a block store instead of a DPAS layout store we can also check that any issues in the 2D block load are not hidden by a 2D block store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants