Skip to content

Commit 2c32865

Browse files
authored
[SYCL][ABI-break] Remove unused host SPIR‑V built‑ins and their symbol exports (#20848)
We don't support host device, so these can be removed.
1 parent af40a52 commit 2c32865

File tree

6 files changed

+0
-68
lines changed

6 files changed

+0
-68
lines changed

sycl/doc/design/CompilerAndRuntimeDesign.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -890,9 +890,6 @@ The SPIR-V specific C++ enumerators and classes are declared in the file:
890890
The SPIR-V specific C++ function declarations are in the file:
891891
`sycl/include/CL/__spirv/spirv_ops.hpp`.
892892
893-
The SPIR-V specific functions are implemented in for the SYCL host device here:
894-
`sycl/source/spirv_ops.cpp`.
895-
896893
### Address spaces handling
897894
898895
SYCL specification uses C++ classes to represent pointers to disjoint memory

sycl/source/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ set(SYCL_COMMON_SOURCES
356356
)
357357

358358
set(SYCL_NON_PREVIEW_SOURCES "${SYCL_COMMON_SOURCES}"
359-
"spirv_ops.cpp"
360359
)
361360

362361

sycl/source/ld-version-script.txt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,6 @@
1717
/* Some functions are also in __host_std, export them as well */
1818
_ZN10__host_std*;
1919

20-
/* Export SPIR-V built-ins for host device */
21-
/* #ifndef __INTEL_PREVIEW_BREAKING_CHANGES */
22-
/* TODO: drop those in the next ABI-breaking window */
23-
_Z23__spirv_GroupWaitEvents*;
24-
_Z22__spirv_ControlBarrier*;
25-
_Z21__spirv_MemoryBarrier*;
26-
_Z20__spirv_ocl_prefetch*;
27-
/* #endif // __INTEL_PREVIEW_BREAKING_CHANGES */
28-
2920
/* Export offload image hooks */
3021
__sycl_register_lib;
3122
__sycl_unregister_lib;

sycl/source/spirv_ops.cpp

Lines changed: 0 additions & 47 deletions
This file was deleted.

sycl/test/abi/sycl_symbols_linux.dump

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77
# REQUIRES: linux
88
# UNSUPPORTED: libcxx
99

10-
_Z20__spirv_ocl_prefetchPKcm
11-
_Z21__spirv_MemoryBarrierN5__spv5ScopeEj
12-
_Z22__spirv_ControlBarrierN5__spv5ScopeES0_j
13-
_Z23__spirv_GroupWaitEventsN5__spv5ScopeEjPPv
1410
_ZN4sycl3_V110__abs_implENS0_3vecIaLi16EEE
1511
_ZN4sycl3_V110__abs_implENS0_3vecIaLi1EEE
1612
_ZN4sycl3_V110__abs_implENS0_3vecIaLi2EEE

sycl/test/abi/sycl_symbols_windows.dump

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3435,10 +3435,6 @@
34353435
?__smoothstep_impl@_V1@sycl@@YA?AVhalf@half_impl@detail@12@V34512@00@Z
34363436
?__smoothstep_impl@_V1@sycl@@YAMMMM@Z
34373437
?__smoothstep_impl@_V1@sycl@@YANNNN@Z
3438-
?__spirv_ControlBarrier@@YAXUScope@__spv@@0I@Z
3439-
?__spirv_GroupWaitEvents@@YAXUScope@__spv@@IPEAPEAX@Z
3440-
?__spirv_MemoryBarrier@@YAXUScope@__spv@@I@Z
3441-
?__spirv_ocl_prefetch@@YAXPEBD_K@Z
34423438
?__sqrt_impl@_V1@sycl@@YA?AV?$vec@M$00@12@V312@@Z
34433439
?__sqrt_impl@_V1@sycl@@YA?AV?$vec@M$01@12@V312@@Z
34443440
?__sqrt_impl@_V1@sycl@@YA?AV?$vec@M$02@12@V312@@Z

0 commit comments

Comments
 (0)