Skip to content

Commit bece203

Browse files
[SYCL][Unittests] Fix IPC unittests (#20804)
The SYCL IPC unittests were not being build and run due to a misconfiguration. This commit fixes the configuration issue and fixes a check in two of the test cases. Signed-off-by: Larsen, Steffen <[email protected]>
1 parent d02286b commit bece203

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

sycl/unittests/Extensions/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,3 +35,4 @@ add_subdirectory(VirtualMemory)
3535
add_subdirectory(NumComputeUnits)
3636
add_subdirectory(FreeFunctionCommands)
3737
add_subdirectory(KernelQueries)
38+
add_subdirectory(InterProcessCommunication)

sycl/unittests/Extensions/InterProcessCommunication/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ add_sycl_unittest(IPCTests OBJECT
22
Memory.cpp
33
)
44

5-
set_target_properties(IPCTests_preview PROPERTIES CXX_STANDARD 20)
6-
set_target_properties(IPCTests_non_preview PROPERTIES CXX_STANDARD 20)
5+
set_target_properties(IPCTests_Preview_Tests PROPERTIES CXX_STANDARD 20)
6+
set_target_properties(IPCTests_Non_Preview_Tests PROPERTIES CXX_STANDARD 20)

sycl/unittests/Extensions/InterProcessCommunication/Memory.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,10 @@ TEST_F(IPCTests, IPCGetPutImplicit) {
112112
syclexp::ipc_memory::handle IPCMemHandle =
113113
syclexp::ipc_memory::get(DummyPtr, Ctxt);
114114
syclexp::ipc_memory::handle_data_t IPCMemHandleData = IPCMemHandle.data();
115-
EXPECT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
116-
EXPECT_EQ(IPCMemHandleData.data(), DummyHandleData);
115+
ASSERT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
116+
EXPECT_EQ(std::memcmp(IPCMemHandleData.data(), DummyHandleData,
117+
DummyHandleDataSize),
118+
0);
117119

118120
// Creating the IPC memory from a pointer should only call "get".
119121
EXPECT_EQ(urIPCGetMemHandleExp_counter, 1);
@@ -126,8 +128,10 @@ TEST_F(IPCTests, IPCGetPutExplicit) {
126128
syclexp::ipc_memory::handle IPCMemHandle =
127129
syclexp::ipc_memory::get(DummyPtr, Ctxt);
128130
syclexp::ipc_memory::handle_data_t IPCMemHandleData = IPCMemHandle.data();
129-
EXPECT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
130-
EXPECT_EQ(IPCMemHandleData.data(), DummyHandleData);
131+
ASSERT_EQ(IPCMemHandleData.size(), DummyHandleDataSize);
132+
EXPECT_EQ(std::memcmp(IPCMemHandleData.data(), DummyHandleData,
133+
DummyHandleDataSize),
134+
0);
131135

132136
// Creating the IPC memory from a pointer should only call "get".
133137
EXPECT_EQ(urIPCGetMemHandleExp_counter, 1);

0 commit comments

Comments
 (0)