Skip to content

Commit e427e2f

Browse files
authored
[SYCL][E2E] Add a test to track UNSUPPORTED tests (#15849)
Similar to XFAIL tests (no-xfail-without-tracker.cpp) adding a requirement to follow UNSUPPORTED by UNSUPPORTED-TRACKER/UNSUPPORTED-INDENDED Adding a test to track the amount and the list of improperly UNSUPPORTED tests. Also update some tests to check the script.
1 parent 13e84cf commit e427e2f

9 files changed

+587
-9
lines changed

sycl/test-e2e/Assert/assert_in_kernels.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: linux
22

3-
// https://github.com/intel/llvm/issues/7634
43
// UNSUPPORTED: hip
4+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
55
//
66
// XFAIL: (opencl && gpu)
77
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364

sycl/test-e2e/Assert/assert_in_multiple_tus.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
// REQUIRES: linux
22

3-
// https://github.com/intel/llvm/issues/7634
43
// UNSUPPORTED: hip
4+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
55
//
6-
// https://github.com/intel/llvm/issues/8832
76
// UNSUPPORTED: cuda
7+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/8832
88
//
99
// XFAIL: (opencl && gpu)
1010
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
1111

12-
// https://github.com/intel/llvm/issues/15029
1312
// UNSUPPORTED: gpu-intel-dg2
13+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/15029
1414

1515
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -I %S/Inputs %S/Inputs/kernels_in_file2.cpp -o %t.out
1616
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}

sycl/test-e2e/Assert/assert_in_multiple_tus_one_ndebug.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// REQUIRES: linux
22

3-
// https://github.com/intel/llvm/issues/7634
43
// UNSUPPORTED: hip
4+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
55
//
6-
// https://github.com/intel/llvm/issues/8832
76
// UNSUPPORTED: cuda
7+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/8832
88
//
99
// XFAIL: (opencl && gpu)
1010
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364

sycl/test-e2e/Assert/assert_in_one_kernel.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: linux
22

3-
// https://github.com/intel/llvm/issues/7634
43
// UNSUPPORTED: hip
4+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
55
//
66
// XFAIL: (opencl && gpu)
77
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364

sycl/test-e2e/Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// FIXME flaky fail on CUDA
2-
// FIXME HIP: https://github.com/intel/llvm/issues/7634
32
// UNSUPPORTED: cuda, hip
3+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/7634
44
//
55
// XFAIL: (opencl && gpu)
66
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364

sycl/test-e2e/Basic/kernel_max_wg_size.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
// https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_intel_grf_size.asciidoc
66
// REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2
77
// UNSUPPORTED: cuda || hip
8+
// UNSUPPORTED-INTENDED: This extension is currently implemented in DPC++ only
9+
// for Intel GPU devices and only when using the Level Zero backend or OpenCL
10+
// backend.
811

912
// clang-format off
1013
#include <sycl/detail/core.hpp>

sycl/test-e2e/README.md

+26
Original file line numberDiff line numberDiff line change
@@ -343,3 +343,29 @@ Once the issue is created, you can update the test by adding `XFAIL` and
343343

344344
If you add `XFAIL` without `XFAIL-TRACKER` directive,
345345
`no-xfail-without-tracker.cpp` test will fail, notifying you about that.
346+
347+
## Marking tests as unsupported
348+
349+
Some tests may be considered unsupported, e.g.:
350+
* the test checks the feature that is not supported by some
351+
backend / device / OS / etc.
352+
* the test is flaky or hangs, so it can't be marked with `XFAIL`.
353+
354+
In these cases the test can be marked with `UNSUPPORTED`. This mark should be
355+
followed by either `UNSUPPORTED-INTENDED` or `UNSUPPORTED-TRACKER` depending on
356+
whether the test is not intended to be run with some feature at all or it was
357+
temporarily disabled due to some issue.
358+
```
359+
// UNSUPPORTED: cuda, hip
360+
// UNSUPPORTED-INTENDED: only supported by backends with SPIR-V IR
361+
362+
// Sporadically fails on DG2.
363+
// UNSUPPORTED: gpu-intel-dg2
364+
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/DDDDD
365+
// *OR*
366+
// UNSUPPORTED-TRACKER: PRJ-1234
367+
```
368+
369+
If you add `UNSUPPORTED` without `UNSUPPORTED-TRACKER` or `UNSUPPORTED-INTENDED`
370+
directive, the `no-unsupported-without-tracker.cpp` test will fail, notifying
371+
you about that.

sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp

+548
Large diffs are not rendered by default.

sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
// This test is intended to ensure that we have no trackers marked as XFAIL
1+
// This test is intended to ensure that we have no tests marked as XFAIL
22
// without a tracker information added to a test.
3+
// For more info see: sycl/test-e2e/README.md
34
//
45
// The format we check is:
56
// XFAIL: lit,features

0 commit comments

Comments
 (0)