Skip to content

[UR] Investigate and deprecate UR_DEVICE_TYPE_ALL #17527

@isaacault

Description

@isaacault

UR_DEVICE_TYPE_ALL doesn't fit properly with the use of the device_types enum. In most instances, vectors of device types are handled and edge cases are written into the code to support UR_DEVICE_TYPE_ALL.

For example, see

// If the adapter can report all device types then it matches.
if (std::find(manifest.device_types.begin(), manifest.device_types.end(),
UR_DEVICE_TYPE_ALL) != manifest.device_types.end()) {
return true;
.

This has implications in the instance where this enum is extended for further device types. The use of this throughout should be investigated and if possible, deprecated in favor of vectors containing explicit device types.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions