[SYCL][Graph] Bugfix: Keep handle to last recorded queue after cleanup #20831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reble
commented
Dec 5, 2025
adamfidel
approved these changes
Dec 5, 2025
Member
adamfidel
left a comment
adamfidel
left a comment
There was a problem hiding this comment.
The code changes look good to me.
The CI failures seem to be unrelated. It looks like a few time outs and unrelated errors in KernelCompiler/sycl_join.cpp and Config/select_device.cpp.
Contributor
Author
|
|
Contributor
Author
|
Failures are unrelated. @intel/llvm-gatekeepers Please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRecordingQueuesis cleared after recording is completed. Which prevents optimization of reusing an available queue for an executable graph object, instead of creating a placeholder queue.