[Encode] VP9 Encode Add boundary check for log2_tile_columns #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
media_softlet/linux/common/codec/ddi/enc/media_libvpx_vp9_next.cpp
Outdated
Show resolved
Hide resolved
User might pass picParam->log2_tile_columns as 0 for >4K width In this scenario Vp9WriteUncompressHeader may crash in while loop or huze loop due to possible col_data negative value. To avoid this added a boundary check and making picParam->log2_tile_columns same as min_log2_tile_cols. Signed-off-by: sachin kumar <[email protected]>
kumarsac
force-pushed
the
vp9_encode_fix
branch
from
888d2e7 to
89e79cb
Compare
kumarsac
changed the title
XinfengZhang
approved these changes
Nov 5, 2025
XinfengZhang
added
verifying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User might pass picParam->log2_tile_columns as 0 for >4K width
In this scenario Vp9WriteUncompressHeader may crash in while loop
or huze loop due to possible col_data negative value.
To avoid this added a boundary check and making picParam->log2_tile_columns
same as min_log2_tile_cols.