safestringlib: Add -Wstrict-prototypes

MRustad · MRustad · commit 3422505052d0 · 2019-12-06T21:42:46.000-08:00
Add -W strict-prototypes and resolve the resulting warnings. Add
static where necessary, and convert non-prototypes into prototypes.

Signed-off-by: Mark Rustad &lt;MRustad@gmail.com&gt;
diff --git a/makefile b/makefile
@@ -3,6 +3,7 @@ MKDIR_P = mkdir -p
 CC=gcc
 CFLAGS := -I${IDIR} -fstack-protector-strong -fPIE -fPIC -O2 -MMD
 CFLAGS += -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wformat-security
+CFLAGS += -Wmissing-prototypes -Wstrict-prototypes
 LDFLAGS=-z noexecstack -z now
 
 ODIR=obj
diff --git a/safeclib/snprintf_support.c b/safeclib/snprintf_support.c
@@ -55,7 +55,7 @@
 #define CHK_FORMAT(X,Y)   (((X)==(Y))?1:0)
 
 
-unsigned int
+static unsigned int
 parse_format(const char *format, char pformatList[], unsigned int maxFormats)
 {
 	unsigned int  numFormats = 0;
@@ -202,7 +202,7 @@ parse_format(const char *format, char pformatList[], unsigned int maxFormats)
 	return numFormats;
 }
 
-unsigned int
+static unsigned int
 check_integer_format(const char format)
 {
 	unsigned int  retValue = 0; // default failure

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@`
`55`	`55`	`#define CHK_FORMAT(X,Y) (((X)==(Y))?1:0)`
`56`	`56`
`57`	`57`
`58`		`-unsigned int`
	`58`	`+static unsigned int`
`59`	`59`	`parse_format(const char *format, char pformatList[], unsigned int maxFormats)`
`60`	`60`	`{`
`61`	`61`	`unsigned int numFormats = 0;`
`@@ -202,7 +202,7 @@ parse_format(const char *format, char pformatList[], unsigned int maxFormats)`
`202`	`202`	`return numFormats;`
`203`	`203`	`}`
`204`	`204`
`205`		`-unsigned int`
	`205`	`+static unsigned int`
`206`	`206`	`check_integer_format(const char format)`
`207`	`207`	`{`
`208`	`208`	`unsigned int retValue = 0; // default failure`