Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XED build with --knc is broken #78

Closed
flobernd opened this issue Nov 16, 2017 · 7 comments
Closed

XED build with --knc is broken #78

flobernd opened this issue Nov 16, 2017 · 7 comments

Comments

@flobernd
Copy link

flobernd commented Nov 16, 2017

Hey there,

it seems like one of the latest changes broke the build with --knc switch.

[WARNING] isa_set referenced by chip model hierarchy,but not used by any instructions: FAT_NOP
[WARNING] isa_set referenced by chip model hierarchy,but not used by any instructions: PREFETCHW
[WARNING] bad isa_set referenced cpuid file: XED_ISA_SET_CLWB
[ERROR] Found bad isa_sets in cpuid input files.
  File "./pysrc/generator.py", line 6445, in <module>
    main()
  File "./pysrc/generator.py", line 6429, in main
    gen_cpuid_map(agi)
  File "./pysrc/generator.py", line 5848, in gen_cpuid_map
    make_cpuid_mappings(agi, mappings)
  File "./pysrc/generator.py", line 5814, in make_cpuid_mappings
    die("Found bad isa_sets in cpuid input files.")
  File "./pysrc/genutil.py", line 83, in die
    traceback.print_stack()

Not sure how to fix this.

@markcharney
Copy link
Contributor

You are correct! I'll take a look.

@markcharney
Copy link
Contributor

I had disabled AVX512 when the KNC ISA was enabled because several instructions have identical encodings (in the VEX space) but different names. The problem here is that the CLWB and CLFLUSHOPT instructions were attached to the SKX chip (which has AVX512). I can omit these when building KNC.

@flobernd
Copy link
Author

flobernd commented Nov 16, 2017

Thanks a lot! This fixes the original issue, but now I get:

[MBUILD WARNING] Command execution failed. Waiting for remaining jobs and exiting.
[STATUS] RUNNING: 3    PENDING: 0    COMPLETED: 108   ERRORS: 1   ELAPSED: 2 secs
'utf-8' codec can't decode byte 0x81 in position 172: invalid start byte

Im trying to build XED on Windows. Got a similar error (but with different position and hex-byte) earlier with the python ../mfile.py examples commandline.

Edit:
Mhh seems to be some kind of race condition. Sometimes it works and sometimes it does not.

@markcharney
Copy link
Contributor

markcharney commented Nov 16, 2017

unicode.... zounds! wonder where that came from... are you using python2 or python3?
Your source is clean? You didn't happen to edit any files? i could not repro this issue. need more information.

@flobernd
Copy link
Author

Im using python 3.6 and did not change any files. I even removed the xed and mbuild directories from my disk and pulled them again (using TortoiseGit in this case).

This did not fix the 'utf-8' error in the first case, but now it "magically" disappeared 😆

@markcharney
Copy link
Contributor

This did not fix the 'utf-8' error in the first case, but now it "magically" disappeared

So it sounds like it did fix the error? Let me know if you are still experiencing an issue.

@flobernd
Copy link
Author

flobernd commented Nov 16, 2017

So it sounds like it did fix the error? Let me know if you are still experiencing an issue.

It's working for now. I'll further investigate and open a seperate issue for the error, if it comes back.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants