fix(mase): handle subjectId null case (#3707)

* feat(auth): add subject to grant

* feat(auth): add subject to grant

* fix(auth): grant access when is undefined

* feat(auth): subject id validation

* fix(auth): fix tests

* Update packages/auth/src/graphql/schema.graphql

Co-authored-by: Max Kurapov <[email protected]>

* feat(auth): throw GrantError instead of Error

* fix(auth): description for subIdFormat

* fix(auth): trx in tests is knex

* fix: grant service to throw only grant errors

* fix(auth): address change requests

* fix(auth): address change requests

* fix tests

* access token optional in grant response

* fix(auth): move accessErrorsMap to grant

* fix(auth): fix test for grant access

* fix(auth): changed interaction generic error message

* use main OpenAPI spec for Auth

* fix(auth): approved grant does not return subject

* fix(auth): remove unused import

Co-authored-by: Max Kurapov <[email protected]>

* fix(auth): make access_token optional in response

* fix(deps): sha.js critical update

* fix(deps): critical update

* Update package.json

Co-authored-by: Max Kurapov <[email protected]>

* update pnpm lock file

* change op specs version

* feat(auth): update idp openapi spec

* feat(auth): make idp standalone

* chore(deps): update axios

* fix(auth): access token in response when it shouldnt

* fix(auth): tests

* try to fix grype scan

* try fix grype

* restore 'fix'

* try fix grype

* try fix grype 2

* feat(localenv): expose subject during consent in mock-ase (#3666)

* feat(localenv): expose subject during consent in mock-ase

* feat: include client name in subject grant line

* fix(mase): grantId not being retrieved

* fix(mase): consent and confirmation texts

* fix: handle subject-only grants properly

---------

Co-authored-by: Cozmin Ungureanu <[email protected]>

* fix(mase): handle subjectId null case

* chore(mase): remove unused SubjectId type

---------

Co-authored-by: Cozmin Ungureanu <[email protected]>
Co-authored-by: Nathan Lie <[email protected]>

Author: 3 people

localenv/mock-account-servicing-entity/app/lib/types.ts

@@ -28,11 +28,6 @@ export interface Access {
   limits?: AccessLimit
 }
 
-export interface SubjectId {
-  id: string
-  format: string
-}
-
 export type InstanceConfig = {
   name: string
   logo: string

localenv/mock-account-servicing-entity/app/routes/mock-idp._index.tsx

@@ -8,7 +8,7 @@ import type { Dispatch, SetStateAction } from 'react'
 import { useEffect, useState } from 'react'
 import { Button } from '~/components'
 import { ApiClient } from '~/lib/apiClient'
-import type { Access, InstanceConfig, SubjectId } from '~/lib/types'
+import type { Access, InstanceConfig } from '~/lib/types'
 import { CONFIG } from '~/lib/parse_config.server'
 
 interface ConsentScreenContext {
@@ -20,7 +20,7 @@ interface ConsentScreenContext {
   returnUrl: string
   accesses: Array<Access> | null
   outgoingPaymentAccess: Access | null
-  subjectId: SubjectId | null
+  subjectId: string | null
   price: GrantAmount | null
   costToUser: GrantAmount | null
   errors: Array<Error>
@@ -64,7 +64,7 @@ function ConsentScreenBody({
   interactId: string
   nonce: string
   returnUrl: string
-  subjectId: SubjectId | null
+  subjectId: string | null
 }) {
   const chooseConsent = (accept: boolean) => {
     const href = new URL(returnUrl)
@@ -82,7 +82,7 @@ function ConsentScreenBody({
             {subjectId && (
               <p>
                 {thirdPartyName} is asking you to confirm ownership of{' '}
-                {subjectId.id}.
+                {subjectId}.
               </p>
             )}
           </div>
@@ -365,14 +365,15 @@ export default function ConsentScreen({ idpSecretParam }: ConsentScreenProps) {
                     : AmountType.UNLIMITED
               )
             }
-            returnUrlObject.searchParams.append(
-              'subjectId',
-              response.payload.subject.sub_ids[0]?.id ?? null
-            )
+
+            const subjectId = response.payload.subject?.sub_ids[0]?.id ?? null
+            if (subjectId) {
+              returnUrlObject.searchParams.append('subjectId', subjectId)
+            }
             setCtx({
               ...ctx,
               accesses: response.payload.access,
-              subjectId: response.payload.subject.sub_ids[0],
+              subjectId,
               outgoingPaymentAccess: outgoingPaymentAccess,
               thirdPartyName: ctx.thirdPartyName,
               thirdPartyUri: ctx.thirdPartyUri,