fix: compare balance to value with assetscale in mind when checking balance (#2001)

compare balance to value with assetscale in mind

Author: Tymmmy

packages/wallet/backend/src/quote/service.ts

@@ -51,23 +51,24 @@ export class QuoteService implements IQuoteService {
       params.userId
     )
 
+    let asset: Pick<Asset, 'scale' | 'code'> | undefined =
+      await this.rafikiClient.getAssetById(assetId)
+    if (!asset) {
+      throw new NotFound()
+    }
+
     const account = await this.accountService.getAccountById(
       params.userId,
       existingWalletAddress.accountId
     )
     const balance = account.balance
 
-    if (Number(balance) < params.amount) {
-      throw new BadRequest('Not enough funds in account')
-    }
+    const originalValue = BigInt((params.amount * 10 ** asset.scale).toFixed())
 
-    let asset: Pick<Asset, 'scale' | 'code'> | undefined =
-      await this.rafikiClient.getAssetById(assetId)
-    if (!asset) {
-      throw new NotFound()
+    if (Number(balance) < originalValue) {
+      throw new BadRequest('Not enough funds in account')
     }
 
-    const originalValue = BigInt((params.amount * 10 ** asset.scale).toFixed())
     let value = originalValue
 
     let paymentUrl = params.receiver