fix: check balance on outgoing payment created webhook (#1956)

Author: dragosp1011

packages/wallet/backend/migrations/20250311101910_update_transactions_columns.js

@@ -0,0 +1,29 @@
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.up = function (knex) {
+  return knex.schema.alterTable('transactions', async (table) => {
+    await knex.raw(
+      [
+        `ALTER TABLE "transactions" DROP CONSTRAINT IF EXISTS "transactions_status_check";`,
+        `ALTER TABLE "transactions" ADD CONSTRAINT "transactions_status_check" CHECK ("status" = ANY (ARRAY['PENDING'::text, 'COMPLETED'::text, 'FAILED'::text, 'EXPIRED'::text]))`
+      ].join('\n')
+    )
+  })
+}
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.down = function (knex) {
+  return knex.schema.alterTable('transactions', async (table) => {
+    await knex.raw(
+      [
+        `ALTER TABLE "transactions" DROP CONSTRAINT IF EXISTS "transactions_status_check";`,
+        `ALTER TABLE "transactions" ADD CONSTRAINT "transactions_status_check" CHECK ("status" = ANY (ARRAY['PENDING'::text, 'COMPLETED'::text, 'REJECTED'::text, 'EXPIRED'::text]))`
+      ].join('\n')
+    )
+  })
+}

packages/wallet/backend/src/rafiki/service.ts

@@ -230,7 +230,7 @@ export class RafikiService implements IRafikiService {
     const walletAddress = await this.getWalletAddress(wh)
     const amount = this.getAmountFromWebHook(wh)
 
-    const { gateHubWalletId } =
+    const { gateHubWalletId, gateHubUserId } =
       await this.getGateHubWalletAddress(walletAddress)
 
     if (!this.validateAmount(amount, wh.type)) {
@@ -247,12 +247,24 @@ export class RafikiService implements IRafikiService {
       secondParty
     )
 
+    const balance = await this.getWalletBalance(
+      gateHubWalletId,
+      gateHubUserId,
+      amount.assetCode
+    )
+    const amountValue = this.amountToNumber(amount)
+
+    if (balance < amountValue) {
+      this.logger.info(
+        `Insufficient funds. Payment amount ${amountValue}, balance ${balance}`
+      )
+      throw new Error('Insufficient funds')
+    }
+
     await this.rafikiClient.depositLiquidity(wh.id)
 
     this.logger.info(
-      `Succesfully held ${this.amountToNumber(
-        amount
-      )} in ${gateHubWalletId}  on ${EventType.OutgoingPaymentCreated}`
+      `Succesfully held ${amountValue} in ${gateHubWalletId}  on ${EventType.OutgoingPaymentCreated}`
     )
   }
 
@@ -463,4 +475,20 @@ export class RafikiService implements IRafikiService {
       this.logger.warn('Error on getting receiver wallet address', e)
     }
   }
+
+  async getWalletBalance(
+    gateHubWalletId: string,
+    gateHubUserId: string,
+    assetCode: string
+  ) {
+    const balances = await this.gateHubClient.getWalletBalance(
+      gateHubWalletId,
+      gateHubUserId
+    )
+
+    return Number(
+      balances.find((balance) => balance.vault.asset_code === assetCode)
+        ?.available ?? 0
+    )
+  }
 }