refactor: remove unused interfaces and types from upload and webdav modules

Author: larryrider

src/services/network/upload/upload.types.ts

@@ -19,7 +19,7 @@ export interface UploadFolderParams {
   reporter: LogReporter;
 }
 
-export interface UploadProgress {
+interface UploadProgress {
   percentage: number;
   currentFile?: string;
 }

src/types/command.types.ts

@@ -89,14 +89,6 @@ export class NotValidFileIdError extends Error {
   }
 }
 
-export class NoRootFolderIdFoundError extends Error {
-  constructor() {
-    super('No root folder id found on your account');
-
-    Object.setPrototypeOf(this, NoRootFolderIdFoundError.prototype);
-  }
-}
-
 export class MissingCredentialsError extends Error {
   constructor() {
     super('Missing credentials, please login first');

src/types/network.types.ts

@@ -12,26 +12,15 @@ export interface NetworkOptions {
 }
 
 export type DownloadProgressCallback = (downloadedBytes: number) => void;
-export type UploadProgressCallback = (uploadedBytes: number) => void;
-export interface NetworkOperationBaseOptions {
+type UploadProgressCallback = (uploadedBytes: number) => void;
+interface NetworkOperationBaseOptions {
   progressCallback?: UploadProgressCallback;
   abortController?: AbortController;
 }
 
-export type UploadOptions = NetworkOperationBaseOptions;
 export type DownloadOptions = NetworkOperationBaseOptions;
 
 export interface SelfsignedCert {
   cert: string | Buffer;
   key: string | Buffer;
 }
-
-export interface UploadTask {
-  contentToUpload: Buffer;
-  urlToUpload: string;
-  index: number;
-}
-
-export interface UploadMultipartOptions extends UploadOptions {
-  parts: number;
-}

src/types/webdav.types.ts

@@ -5,10 +5,6 @@ export abstract class WebDavMethodHandler {
   abstract handle(request: Request, response: Response): Promise<void>;
 }
 
-export type WebDavMethodHandlerOptions = {
-  debug: boolean;
-};
-
 export type WebDavRequestedResource = {
   url: string;
   name: string;

test/services/network/network-facade.service.test.ts

@@ -1,35 +1,15 @@
 import { describe, expect, test, vi } from 'vitest';
 import { NetworkFacade } from '../../../src/services/network/network-facade.service';
-import { SdkManager } from '../../../src/services/sdk-manager.service';
 import path from 'node:path';
 import { createReadStream } from 'node:fs';
 import { DownloadService } from '../../../src/services/network/download.service';
 import { Readable } from 'node:stream';
 import axios from 'axios';
 import { fail } from 'node:assert';
-import { Environment } from '@internxt/inxt-js';
-import { ConfigService } from '../../../src/services/config.service';
-import { UserFixture } from '../../fixtures/auth.fixture';
 import { UsageService } from '../../../src/services/usage.service';
+import { getEnvironmentMock, getNetworkMock } from '../../fixtures/webdav.fixture';
 
 describe('Network Facade Service', () => {
-  const getNetworkMock = () => {
-    return SdkManager.instance.getNetwork({
-      user: 'user',
-      pass: 'pass',
-    });
-  };
-
-  const getEnvironmentMock = () => {
-    return new Environment({
-      bridgeUser: 'user',
-      bridgePass: 'pass',
-      bridgeUrl: ConfigService.instance.get('NETWORK_URL'),
-      encryptionKey: UserFixture.mnemonic,
-      appDetails: SdkManager.getAppDetails(),
-    });
-  };
-
   test('when a file is uploaded, then the upload functionality is called', async () => {
     const mockEnvironment = {
       upload: vi.fn(),