Skip to content

fix(BaseForm): Prevent Enter key from submitting form #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(BaseForm): Prevent Enter key from submitting form #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/lib/forms/BaseForm/BaseForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,18 @@
import { Form } from "semantic-ui-react";

export class BaseForm extends Component {
handleKeyDown = (event) => {
if (event.key === "Enter") {
// Prevent enter key from propagating events to other elements and from submitting the form
event.preventDefault();
}
}

Check failure on line 19 in src/lib/forms/BaseForm/BaseForm.js

View workflow job for this annotation

GitHub Actions / Tests (18.x) 

Insert `;`

Check failure on line 19 in src/lib/forms/BaseForm/BaseForm.js

View workflow job for this annotation

GitHub Actions / Tests (16.x) 

Insert `;`

render() {
const { formik, onSubmit, children } = this.props;
return (
<Formik onSubmit={onSubmit} {...formik}>
<Form>{children}</Form>
<Form onKeyDown={this.handleKeyDown}>{children}</Form>
</Formik>
);
}
Expand Down
Loading