fix(messaging, android): purge message store to limit first, add second

previously we added before purging, so if close to an OOM we would trigger it,
if an app update is pushed with this change, it will ideally recover completely
from this situation by purging the store down before any new data is added

Author: mikehardy

packages/messaging/android/src/main/java/io/invertase/firebase/messaging/ReactNativeFirebaseMessagingStoreImpl.java

@@ -28,18 +28,21 @@ public void storeFirebaseMessage(RemoteMessage remoteMessage) {
           reactToJSON(remoteMessageToWritableMap(remoteMessage)).toString();
       //      Log.d("storeFirebaseMessage", remoteMessageString);
       UniversalFirebasePreferences preferences = UniversalFirebasePreferences.getSharedInstance();
-      preferences.setStringValue(remoteMessage.getMessageId(), remoteMessageString);
-      // save new notification id
-      String notificationIds = preferences.getStringValue(S_KEY_ALL_NOTIFICATION_IDS, "");
-      notificationIds += remoteMessage.getMessageId() + DELIMITER; // append to last
-      preferences.setStringValue(S_KEY_ALL_NOTIFICATION_IDS, notificationIds);
 
-      // check and remove old notifications message
+      // remove old notifications message before store to free space as needed
+      String notificationIds = preferences.getStringValue(S_KEY_ALL_NOTIFICATION_IDS, "");
       List<String> allNotificationList = convertToArray(notificationIds);
-      while (allNotificationList.size() > MAX_SIZE_NOTIFICATIONS) {
+      while (allNotificationList.size() > MAX_SIZE_NOTIFICATIONS - 1) {
         clearFirebaseMessage(allNotificationList.get(0));
         allNotificationList.remove(0);
       }
+
+      // now refetch the ids after possible removals, and store the new message
+      notificationIds = preferences.getStringValue(S_KEY_ALL_NOTIFICATION_IDS, "");
+      preferences.setStringValue(remoteMessage.getMessageId(), remoteMessageString);
+      // save new notification id
+      notificationIds += remoteMessage.getMessageId() + DELIMITER; // append to last
+      preferences.setStringValue(S_KEY_ALL_NOTIFICATION_IDS, notificationIds);
     } catch (JSONException e) {
       e.printStackTrace();
     }