Skip to content
This repository was archived by the owner on Aug 23, 2020. It is now read-only.
This repository was archived by the owner on Aug 23, 2020. It is now read-only.

Stop solidifying when asking for previously pruned transactions #1371

@GalRogozinski

Description

@GalRogozinski

Description

While solidifying transactions we might start requesting old transactions that have been pruned.
We want to stop once we recognize this.

Motivation

Optimization

Requirements

  1. When we check solidity and we encounter a tx that is in the Cuckoo filter we set a deletedScore to 1.
    We don't persist the tx but save it in local memory
  2. We start to recursively request its parents and if they are also in the cuckoo filter increment deletedProbability.
  3. If we reach a score of 10 we abort.
  4. If we find one parent that is not in the cuckoo filter we assume that the rest are false positives.

Open Questions (optional)

Do we need to clear the cuckoo filter of extremely old txs in order to decrease false positive rates?

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions