Relax output suppression (--loglevel) to not suppress Vivado simulation results

[jhegeman]

The output formatter used for Vivado output is a bit harsh. Any line that is not actively identified as a specific log level is suppressed unless the log level is set looser than INFO.
One of the side-effects of this choice is that even with --loglevel=INFO, all Vivado simulation output is suppressed. (Unless one gets into the habit of prefixing simulation output with 'INFO'.)

In my opinion, anything not explicitly marked with a log level should be considered informational. So I'd like to propose changing the '>=' in the following line to '>'.
https://github.com/ipbus/ipbb/blob/develop/src/ipbb/tools/xilinx/vivado_common.py#L161

[jhegeman]

Good morning. Has anyone had time to think about this one? Seems harmless, no?

Jeroen

[tswilliams]

Seems fine to me - though when making this change, it would be good to confirm exactly what lines in the output of a couple of standard builds are moved from debug to info level (e.g. an EMP build and/or maybe a TCDS build - I could check this on the EMP side).

[jhegeman]

Ok. I have performed a few simulation runs and a few full project builds, and captured the output. Basically: pre-mod and post-mod runs of:

• ipbb vivado --loglevel=all simulate
• ipbb vivado --loglevel=info simulate
• ipbb vivado --loglevel=all generate-project
• ipbb vivado --loglevel=info generate-project
• ipbb vivado --loglevel=all synth -j 4 impl -j 4 bitfile memcfg package
• ipbb vivado --loglevel=info synth -j 4 impl -j 4 bitfile memcfg package

All outputs are attached. To first order: the post 'info' output is almost the same as the pre 'all' output. This mainly makes a difference for the Vivado simulation cases, because the pre 'info' output drops all output from the simulation itself.

[jhegeman]

pre_sim_all.txt.gz
pre_sim_info.txt.gz
pre_gen_all.txt.gz
pre_gen_info.txt.gz
pre_synth_all.txt.gz
pre_synth_info.txt.gz

post_sim_all.txt.gz
post_sim_info.txt.gz
post_gen_all.txt.gz
post_gen_info.txt.gz
post_synth_all.txt.gz
post_synth_info.txt.gz