Skip to content

Commit ff5c090

Browse files
committed
feat(win): trusted signinging with azure
this may require proile name, azure permissions and secrets to be adjusted before it actually works
1 parent 5aff369 commit ff5c090

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

.github/workflows/ci.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,6 @@ jobs:
230230
max_attempts: 2
231231
# GH token for attaching atrifacts to release draft on tag build
232232
github_token: ${{ secrets.github_token }}
233-
# Windows signing
234-
windows_certs: ${{ secrets.windows_certs }}
235-
windows_certs_password: ${{ secrets.windows_certs_password }}
236233
# Apple signing
237234
mac_certs: ${{ secrets.mac_certs }}
238235
mac_certs_password: ${{ secrets.mac_certs_password }}
@@ -244,6 +241,10 @@ jobs:
244241
# Apple notarization
245242
APPLEID: ${{ secrets.apple_id }}
246243
APPLEIDPASS: ${{ secrets.apple_id_pass }}
244+
# Windows Azure Trusted Signing
245+
AZURE_TENANT_ID: ${{secrets.AZURE_TENANT_ID}}
246+
AZURE_CLIENT_ID: ${{secrets.AZURE_CLIENT_ID}}
247+
AZURE_CLIENT_SECRET: ${{secrets.AZURE_CLIENT_SECRET}}
247248

248249
- name: Show dist/
249250
run: du -sh dist/ && ls -l dist/

electron-builder.yml

+15
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,29 @@ dmg:
4343
type: link
4444
path: /Applications
4545

46+
win:
47+
target:
48+
- nsis
49+
# TODO - portable
50+
publisherName: 'IPFS Project'
51+
rfc3161TimeStampServer: 'http://timestamp.acs.microsoft.com'
52+
azureSignOptions:
53+
endpoint: 'https://eus.codesigning.azure.net'
54+
certificateProfileName: 'ipfs-desktop'
55+
codeSigningAccountName: 'pl-code-signing'
56+
4657
nsis:
58+
artifactName: ${name}-setup-${version}-${os}-${arch}.${ext}
4759
include: assets/build/nsis.nsh
4860
oneClick: false
4961
warningsAsErrors: false
5062
perMachine: false
5163
allowElevation: true
5264
allowToChangeInstallationDirectory: true
5365

66+
portable:
67+
artifactName: ${name}-portable-${version}-${os}-${arch}.${ext}
68+
5469
linux:
5570
artifactName: ${name}-${version}-${os}-${arch}.${ext}
5671
executableName: ipfs-desktop

0 commit comments

Comments
 (0)