Skip to content

Commit 4682bea

Browse files
committed
Skip PickleSerializer tests on Django 5 and above
1 parent c905659 commit 4682bea

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

password_policies/tests/test_middleware.py

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ def test_password_change_required_enforced_redirect(self):
7474
p.delete()
7575

7676

77-
@override_settings(SESSION_SERIALIZER='django.contrib.sessions.serializers.JSONSerializer')
7877
class PasswordPoliciesMiddlewareJsonSerializerTest(TestCase):
7978
def setUp(self):
8079
self.user = create_user()

password_policies/tests/test_settings.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"django.contrib.messages.middleware.MessageMiddleware",
6666
)
6767

68-
SESSION_SERIALIZER = "django.contrib.sessions.serializers.PickleSerializer"
68+
SESSION_SERIALIZER = "django.contrib.sessions.serializers.JSONSerializer"
6969

7070

7171
MEDIA_URL = "/media/somewhere/"

password_policies/tests/test_views.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
from unittest import skipIf
2+
3+
from django import VERSION as DJANGO_VERSION
14
from django.core import signing
2-
from django.conf import settings as django_settings
35
from django.test import Client, TestCase, override_settings
46
from django.utils import timezone
57
from django.urls.base import reverse
@@ -117,6 +119,7 @@ def test_password_reset_complete(self):
117119
)
118120
assert res.status_code == 200
119121

122+
@skipIf(DJANGO_VERSION >= (5, 0), 'PickleSerializer not supported in this version')
120123
@override_settings(SESSION_SERIALIZER='django.contrib.sessions.serializers.PickleSerializer', USE_TZ=False)
121124
@freeze_time("2021-07-21T17:00:00.000000")
122125
def test_pickle_serializer_set_datetime_USE_TZ_false(self):
@@ -146,6 +149,7 @@ def test_pickle_serializer_set_datetime_USE_TZ_false(self):
146149
self.assertEqual(string_to_datetime(session[settings.PASSWORD_POLICIES_LAST_CHANGED_SESSION_KEY]),
147150
timezone.now())
148151

152+
@skipIf(DJANGO_VERSION >= (5, 0), 'PickleSerializer not supported in this version')
149153
@override_settings(SESSION_SERIALIZER='django.contrib.sessions.serializers.PickleSerializer', USE_TZ=True)
150154
@freeze_time("2021-07-21T17:00:00.000000")
151155
def test_pickle_serializer_set_datetime_USE_TZ_true(self):
@@ -175,6 +179,7 @@ def test_pickle_serializer_set_datetime_USE_TZ_true(self):
175179
self.assertEqual(string_to_datetime(session[settings.PASSWORD_POLICIES_LAST_CHANGED_SESSION_KEY]),
176180
timezone.now())
177181

182+
@skipIf(DJANGO_VERSION >= (5, 0), 'PickleSerializer not supported in this version')
178183
@override_settings(SESSION_SERIALIZER='django.contrib.sessions.serializers.PickleSerializer', USE_TZ=True)
179184
@freeze_time("2021-07-21T18:00:00.000000+0100")
180185
def test_pickle_serializer_set_datetime_USE_TZ_true_localized(self):

0 commit comments

Comments
 (0)