Ipmitool sends incorrect format of Platform Event when it's using SSIF (SMBUS System Interface)

[AlexanderAmelkin]

Reported by: duythanhphan
Original Ticket: ipmitool/bugs/504

Hi,

As item "29.6 - System Interface Event Request Message Format" in IPMI spec v2 (Document Revision 1.1, October 1, 2013) mentioned that SSIF (SMBUS System Interface) uses the same format as KCS. It means that the Platform Event message sent via SSIF should have an extra Generator ID byte like KCS but the current code did not check Channel Medium Type is SMBUS to add this byte into the message. Currently, it only adds this extra byte when Channel Medium Type is 0x0C which means KCS, BT or SMIC. Please check below code in lib/ipmi_event.c:

503 /* setup Platform Event Message command /
504 memset(&req, 0, sizeof(req));
505 req.msg.netfn = IPMI_NETFN_SE;
506 req.msg.cmd = 0x02;
507 req.msg.data = rqdata;
508 req.msg.data_len = 7;
509
510 chmed = ipmi_current_channel_medium(intf);
511 if (chmed == IPMI_CHANNEL_MEDIUM_SYSTEM) {
512 / system interface, need extra generator ID */
513 rqdata[0] = 0x41; // As per Fig. 29-2 and Table 5-4
514 req.msg.data_len = 8;
515 }

Thanks,
Duyt Thanh Phan