update notebook lint config

run both via ruff and nbqa

- ruff notebook support doesn't handle namespace rules well with cell magics (F)
- nbqa temp files don't handle isort rules well
- erroneous success status in ruff check with --fix

Author: minrk

.pre-commit-config.yaml

@@ -10,18 +10,28 @@ repos:
           - "--fix"
         exclude_types:
           - jupyter
+      - id: ruff
+        name: ruff (notebooks)
+        args:
+          - "--fix"
+        types:
+          - jupyter
       - id: ruff-format
+        # run via nbqa to handle cell magics
         exclude_types:
           - jupyter
   # run ruff via nbqa, which has better and configurable handling of cell magics
   # than ruff itself
+  # but has trouble with isort rules
   - repo: https://github.com/nbQA-dev/nbQA
     rev: 1.9.0
     hooks:
       - id: nbqa-ruff-format
       - id: nbqa-ruff-check
         args:
           - --fix
+          # isort rules get confused in the temporary files
+          - --ignore=I
   - repo: https://github.com/pre-commit/mirrors-prettier
     rev: v4.0.0-alpha.8
     hooks:

docs/source/examples/Futures.ipynb

@@ -171,9 +171,7 @@
   {
    "cell_type": "code",
    "execution_count": 7,
-   "metadata": {
-    "scrolled": true
-   },
+   "metadata": {},
    "outputs": [
     {
      "data": {
@@ -416,7 +414,7 @@
    },
    "outputs": [],
    "source": [
-    "def task(n):\n",
+    "def interactive_task(n):\n",
     "    \"\"\"Generates a 1xN array and computes its 2-norm\"\"\"\n",
     "    import numpy\n",
     "    from numpy.linalg import norm\n",
@@ -542,8 +540,8 @@
     }
    ],
    "source": [
-    "print(\"Local time:\")\n",
-    "%time ref = list(map(task, sizes))"
+    "%%time\n",
+    "ref = list(map(task, sizes))"
    ]
   },
   {

docs/source/examples/Monte Carlo Options.ipynb

@@ -91,7 +91,8 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "%px from mpi4py.MPI import COMM_WORLD as MPI"
+    "%%px\n",
+    "from mpi4py.MPI import COMM_WORLD as MPI"
    ]
   },
   {

docs/source/examples/Using Dill.ipynb

@@ -1024,7 +1024,7 @@
    ],
    "source": [
     "%%px\n",
-    "dask_worker.data"
+    "dask_worker.data  # noqa"
    ]
   },
   {
@@ -1052,7 +1052,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.9.6"
+   "version": "3.11.9"
   },
   "widgets": {
    "application/vnd.jupyter.widget-state+json": {