Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document DNS Auto Allocation Version 2 #15931

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Conversation

kfaseela
Copy link
Member

Description

Attempt to document istio/istio#51828

Fixes #15846

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@kfaseela kfaseela requested a review from a team as a code owner November 13, 2024 14:56
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 13, 2024
Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Faseela K <[email protected]>
@dhawton dhawton added the cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch label Nov 13, 2024
Copy link
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

@kfaseela
Copy link
Member Author

cc @ilrudie @howardjohn

Signed-off-by: Faseela K <[email protected]>
@@ -27,7 +27,7 @@ snip_getting_started_1
# deploy test application
snip_dns_capture_in_action_2

# configure service entries and verify
# configure service entries #and verify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# configure service entries #and verify
# configure service entries and verify

@istio-testing istio-testing merged commit 2e90b6c into istio:master Nov 15, 2024
13 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #15939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch kind/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 IP Autoallocation Controller Documentation Gaps
6 participants