-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document DNS Auto Allocation Version 2 #15931
Merged
Merged
+126
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faseela K <[email protected]>
istio-testing
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 13, 2024
Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Faseela K <[email protected]>
dhawton
added
the
cherrypick/release-1.24
Set this label on a PR to auto-merge it to the release-1.24 branch
label
Nov 13, 2024
dhawton
reviewed
Nov 13, 2024
content/en/docs/ops/configuration/traffic-management/dns-proxy/index.md
Outdated
Show resolved
Hide resolved
dhawton
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits
content/en/docs/ops/configuration/traffic-management/dns-proxy/index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Faseela K <[email protected]>
ilrudie
reviewed
Nov 13, 2024
content/en/docs/ops/configuration/traffic-management/dns-proxy/index.md
Outdated
Show resolved
Hide resolved
4 tasks
bleggett
reviewed
Nov 13, 2024
content/en/docs/ops/configuration/traffic-management/dns-proxy/index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Faseela K <[email protected]>
Signed-off-by: Faseela K <[email protected]>
bleggett
approved these changes
Nov 15, 2024
@@ -27,7 +27,7 @@ snip_getting_started_1 | |||
# deploy test application | |||
snip_dns_capture_in_action_2 | |||
|
|||
# configure service entries and verify | |||
# configure service entries #and verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# configure service entries #and verify | |
# configure service entries and verify |
In response to a cherrypick label: new pull request created: #15939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherrypick/release-1.24
Set this label on a PR to auto-merge it to the release-1.24 branch
kind/docs
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to document istio/istio#51828
Fixes #15846
Reviewers